Skip to content

[DeadCode] Skip annotation docblocks in RemoveParentDelegatingClassMethodRector #8459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Sep 4, 2026
Merged

[DeadCode] Skip annotation docblocks in RemoveParentDelegatingClassMethodRector #8459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdc4e33
[DeadCode] Skip any annotation docblock in RemoveParentDelegatingClas…
TomasVotruba Sep 4, 2026
91f5dbb
[ci-review] Rector Rectify
actions-user Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...ssMethod/RemoveParentDelegatingClassMethodRector/Fixture/skip_annotation_docblock.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingClassMethodRector\Fixture;

use Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingClassMethodRector\Source\SomeParentCommand;

final class SkipAnnotationDocblock extends SomeParentCommand
{
/**
* @Route("/first", methods={"GET"})
*/
public function anotherMethod(): void
{
parent::anotherMethod();
}
}
15 changes: 3 additions & 12 deletions rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingClassMethodRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Rector\DeadCode\Rector\ClassMethod;

use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocChildNode;
use PhpParser\Node;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
Expand All @@ -12,6 +13,7 @@
use PhpParser\Node\Stmt\Expression;
use PhpParser\Node\Stmt\Return_;
use PhpParser\NodeVisitor;
use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\ExtendedMethodReflection;
use PHPStan\Reflection\ExtendedParameterReflection;
Expand Down Expand Up @@ -115,18 +117,7 @@ public function refactor(Node $node): ?int
private function hasRefiningDocblock(ClassMethod $classMethod): bool
{
$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($classMethod);

return $phpDocInfo->hasByNames(
[
'@param',
'@phpstan-param',
'@psalm-param',
'@return',
'@phpstan-return',
'@psalm-return',
'@deprecated',
]
);
return array_any($phpDocInfo->getPhpDocNode()->children, fn(PhpDocChildNode $phpDocChildNode): bool => $phpDocChildNode instanceof PhpDocTagNode);
}

private function matchParentMethodReflection(ClassMethod $classMethod): ?ExtendedMethodReflection
Expand Down
Loading