[DeadCode] Skip annotation docblocks in RemoveParentDelegatingClassMethodRector - #8459
Merged
Merged
Conversation
…sMethodRector Fixes #9887 Claude-Session: https://claude.ai/code/session_01S1dksw9XmHtE7egqy9Yx5J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9887
RemoveParentDelegatingClassMethodRectorremoved a child method that only delegates to its parent even when the child method carried a docblock annotation such as@Route(...)or OpenAPI@OA\Get(...). Those annotations carry intent the parent does not have (routing, spec generation), so removing the method silently drops them.The
hasRefiningDocblock()bail-out only checked a fixed whitelist of tags (@param,@return,@deprecated, ...). It now bails on any docblock tag/annotation, so a delegating method with a meaningful docblock is kept.Added
skip_annotation_docblock.php.incfixture covering the reported@Routecase.