Repository navigation
chore: scoria の導入と依存更新 (2026-10-18) - #36
Merged
Merged
Conversation
TypeScript は ~6.0.3 に据え置き(7 は vue-tsc / typescript-eslint が未対応)。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- scoria を devDependencies に追加し yarn quality で走らせる - c8 で coverage を取る(test:coverage) - scoria.config.json と .scoria/baseline.json を記録 - scoria ワークフローを追加(report のみ、SARIF をコードスキャンへ) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scoria が node >=24 を要求し、Node 22 では yarn install が失敗するため(engines も >=24)。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Merged
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
CODEX VERDICT: LGTM
FINDINGS COMPLETE: I read every hunk of the diff and this is every finding I have. |
Member
Author
Codex exchange — markdownPrompt sent: Codex reply (verbatim) |
…-2026-10-18 # Conflicts: # package.json # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn upgrade --latest→yarn-deduplicate)。今回は major 更新なし(patch / minor のみ)scoria@^0.4.0)を GUIChatPluginSpreadsheet と同じ形で導入yarn quality(=scoria)、scoria.config.json(library / vue, ts / mode: report)、.scoria/baseline.jsonc8(yarn test:coverage=c8 yarn run test、.c8rc.json、coverage/は gitignore)。テストはtsx --testなので Spreadsheet のtest:suitesに当たるのはtest.github/workflows/scoria.ymlを Spreadsheet からそのまま追加(計測ジョブはcontents: read、SARIF アップロードはsecurity-events: writeの別ジョブで SHA 固定、checkout はpersist-credentials: false)engines.nodeを>=24にし、CI の行列を Node 24.x / 26.x に変更plans/chore-scoria.mdItems to Confirm / Review
engines: node >=24で、Yarn v1 は engines 不一致で install を失敗させるため。パッケージのenginesも>=24にした(利用者側への影響を確認してほしい)~6.0.3に据え置き:yarn upgrade --latestで 7 に上がるが、vue-tsc / typescript-eslint が 7 に未対応のため(メンテ方針どおり)braces(GHSA-vfj7-8cjw-p6xm、scoria → jscpd → fast-glob → micromatch → braces)。修正版が未公開で今は消せない。開発依存なので利用者には届かない(Spreadsheet と同じ)。scoria 導入前の依存は audit 0 件vite-plugin-dts(vite.config で未使用、d.ts は vue-tsc で出している)、dependenciesのminimatch(src から import なし。resolutionsでも固定している)。消してよければ別 PR でyarn removeする.scoria/baseline.jsonのrootに作業したクローンの絶対パスが入る(Spreadsheet も同様にローカルパスが入っている)jsonDataを渡し View はdata.markdownを読むためで、この PR 以前からの挙動(未修正)User Prompt
Verification
rm -rf node_modules && yarn install --frozen-lockfileyarn lint→yarn build→yarn typecheck→yarn test→yarn test:coverage→yarn quality:すべて成功(format script はこのリポに無い)yarn audit:上記 braces の 1 件のみyarn devを headless Chrome で読み込み、画面が描画されること(white screen でない)と、console error が出ていないことを確認。sample ボタンのクリックなどの操作までは試していない🤖 Generated with Claude Code
追記: 再利用ワークフローとバッジ
.github/workflows/scoria.ymlを、isamu/lab の再利用ワークフロー(scoria-measure.yml、レビュー済みの commit SHA で固定)を呼ぶ形に置き換えた。計測・code scanning へのアップロードに加え、mainへの push でbadgesブランチにバッジ用 JSON を置く。ci: scoria を再利用ワークフローで回し、README にバッジを出す GUIChatPluginSpreadsheet#53 と同じ形badgesブランチができるまでは表示されないcontents: writeとsecurity-events: writeを渡すが、プロジェクトのコードは読み取り権限だけのジョブで動く