Repository navigation
chore: 使っていない依存を消す - #37
Merged
Merged
Conversation
vite-plugin-dts と minimatch はどこからも読み込まれていない。 resolutions の minimatch は推移的依存が使うので残す。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
CODEX VERDICT: LGTM
FINDINGS COMPLETE: I read every hunk of the diff and this is every finding I have. |
Member
Author
Codex exchange — markdown-37Prompt sent: Codex reply (verbatim) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarn removeで消すvite-plugin-dts(devDependencies):vite.config で読み込まれていない。d.ts はvue-tsc --emitDeclarationOnlyで出しているminimatch(dependencies):src / demo / vite.config / tsconfig / eslint.config / scripts のどこからも参照がないplans/chore-remove-unused-deps.mdItems to Confirm / Review
resolutions.minimatchは残した:yarn why minimatchで eslint / @eslint/config-array / @typescript-eslint/typescript-estree が推移的に minimatch を使っているため。ただしこれらの要求範囲はいずれも^10.2.xで、現状この resolution が版を動かしているわけではない。不要と判断するなら別途消せるdependenciesからminimatchが外れるので、このパッケージの利用者の install から minimatch が落ちる(ソースは使っていないので影響はないはず)yarn auditには main 時点からあるsource-map-js(High、vue / @tailwindcss/vite 経由)が出る。この PR では触っていない。chore: scoria の導入と依存更新 (2026-10-18) #36 の依存更新で解消されるUser Prompt
Verification
rm -rf node_modules && yarn install --frozen-lockfileyarn lint(error 0、既存の warning のみ)→yarn build(dist/index.d.ts・dist/vue/index.d.tsが出ることも確認)→yarn typecheck→yarn test:すべて成功🤖 Generated with Claude Code