Skip to content

chore: 使っていない依存を消す - #37

Merged
isamu merged 1 commit into
mainfrom
chore/remove-unused-deps
Oct 18, 2026
Merged

isamu merged 1 commit into
mainfrom
chore/remove-unused-deps

Conversation

@isamu

@isamu isamu commented Oct 17, 2026

Copy link
Copy Markdown
Member

Summary

  • 使っていない依存を yarn remove で消す
    • vite-plugin-dts(devDependencies):vite.config で読み込まれていない。d.ts は vue-tsc --emitDeclarationOnly で出している
    • minimatch(dependencies):src / demo / vite.config / tsconfig / eslint.config / scripts のどこからも参照がない
  • 方針は plans/chore-remove-unused-deps.md

Items to Confirm / Review

  • resolutions.minimatch は残した:yarn why minimatch で eslint / @eslint/config-array / @typescript-eslint/typescript-estree が推移的に minimatch を使っているため。ただしこれらの要求範囲はいずれも ^10.2.x で、現状この resolution が版を動かしているわけではない。不要と判断するなら別途消せる
  • dependencies から minimatch が外れるので、このパッケージの利用者の install から minimatch が落ちる(ソースは使っていないので影響はないはず)
  • yarn audit には main 時点からある source-map-js(High、vue / @tailwindcss/vite 経由)が出る。この PR では触っていない。chore: scoria の導入と依存更新 (2026-10-18) #36 の依存更新で解消される
  • ソースの変更はなし

User Prompt

  • 使っていない依存を消す

Verification

  • 消す前に、src / demo / vite.config / tsconfig / eslint.config / index.html / package.json scripts / .github に参照が無いことを grep で確認
  • クリーン install:rm -rf node_modules && yarn install --frozen-lockfile
  • yarn lint(error 0、既存の warning のみ)→ yarn build(dist/index.d.ts・dist/vue/index.d.ts が出ることも確認)→ yarn typecheck → yarn test:すべて成功

🤖 Generated with Claude Code

vite-plugin-dts と minimatch はどこからも読み込まれていない。
resolutions の minimatch は推移的依存が使うので残す。

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@isamu

isamu commented Oct 18, 2026 •

Copy link
Copy Markdown
Member Author

CODEX VERDICT: LGTM

  • No P1/P2/P3 findings.
  • The package consumer surface is unchanged: marked remains the only runtime dependency, published files remain dist, and the removed packages are not imported or configured anywhere.
  • resolutions.minimatch is correctly retained for transitive ESLint / TypeScript-ESLint users; yarn why minimatch confirms those paths.
  • The lockfile pruning is consistent: only the removed vite-plugin-dts tree and now-unused request aliases were removed.
  • Security/supply-chain and CI permissions: no relevant changes in this diff.
  • Verification: yarn lint passed with 0 errors (6 existing warnings), yarn typecheck passed, yarn build passed, and yarn test passed (13/13).
Axis Result
Correctness / edge cases No findings
Package-consumer behaviour No findings
Security / CI / supply chain No findings
Tests No findings; all applicable scripts pass
Repository consistency No findings
Documentation No misleading documentation changes

FINDINGS COMPLETE: I read every hunk of the diff and this is every finding I have.

@isamu

isamu commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

Codex exchange — markdown-37

Prompt sent:

Review PR #37 at https://github.com/receptron/GUIChatPluginMarkdown/pull/37 (head 27b4e80). The checkout to read is /private/tmp/claude-501/-Users-isamu-ss-llm-lab/05aa564a-1040-4f30-b316-122f241bad1d/scratchpad/repos/markdown-37 (already on the PR branch, dependencies installed). Diff: git -C /private/tmp/claude-501/-Users-isamu-ss-llm-lab/05aa564a-1040-4f30-b316-122f241bad1d/scratchpad/repos/markdown-37 diff origin/main...HEAD. Read the repo's package.json scripts and run what applies (lint, typecheck, build, test) with yarn.
Tier S. THIS IS THE ONLY ROUND YOU ARE GUARANTEED. Read the WHOLE diff; every finding now. Post inline (gh api repos/receptron/GUIChatPluginMarkdown/pulls/37/comments) or top-level (gh pr comment 37 -R receptron/GUIChatPluginMarkdown).
AXES — answer every line, even "no findings": correctness/edge cases; behaviour change for package consumers (dependencies vs devDependencies, peerDependencies, engines, published files); security (CI permissions, supply chain); tests go red if behaviour breaks; consistency with the repo; docs that would cause a WRONG CHANGE if believed (merely behind is N).
Removes vite-plugin-dts and minimatch from package.json; resolutions.minimatch kept because eslint deps resolve minimatch transitively. Verify nothing imports or configures either package (src, demo, vite.config, tsconfig, eslint config, scripts).
Each finding: SEVERITY P1/P2/P3/N, EVERY SITE, SMALLEST FIX, WHAT WOULD CHANGE YOUR MIND.
Settled decisions (user): Node 22 support is dropped where engines >=24 is set; TypeScript stays on 6.x (typescript-eslint does not support 7); the braces High advisory via scoria>jscpd is accepted (devDependency, no fix upstream). LEDGER: _no findings yet_.
END WITH ONE TOP-LEVEL COMMENT: line 1 'CODEX VERDICT: LGTM' or 'CODEX VERDICT: CHANGES REQUESTED' + bullets; axis table; 'FINDINGS COMPLETE: I read every hunk of the diff and this is every finding I have.' Do not apply fixes.
Codex reply (verbatim)
Reviewed PR #37 at head `27b4e80`.

- Verdict: LGTM
- No findings across correctness, consumer behavior, security, tests, consistency, or docs.
- `yarn lint`, `typecheck`, `build`, and `test` all passed.
- Posted the required top-level review: [comment](https://github.com/receptron/GUIChatPluginMarkdown/pull/37#issuecomment-6243989126).

@isamu
isamu merged commit 6390c50 into main Oct 18, 2026
12 checks passed
@isamu
isamu deleted the chore/remove-unused-deps branch October 18, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant