Repository navigation
docs: explain numeric converter culture - #1005
Merged
Merged
Conversation
- Describe current culture for numeric defaults, hints, and nullable values. - Quote the French float formatting example from the binding project. - Explain how to supply an invariant conversion explicitly.
Merged
4 tasks done
Arhell
approved these changes
Oct 13, 2026
glennawatson
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the consistent current-culture contract for numeric converters and generated bindings.
Why
Companion to reactiveui/ReactiveUI.Binding.SourceGenerators#179, which fixes reactiveui/ReactiveUI.Binding.SourceGenerators#175. The converter page currently describes the Single-only invariant exception that the code change removes.
Breaking changes
None in this documentation change. The companion code PR changes unhinted float formatting to use current culture.
How this was verified
Built the complete website with strict link checking and ran the quoted converter example. The documented output matches the example's French decimal separator.
Notes for the reviewer
Merge alongside or after reactiveui/ReactiveUI.Binding.SourceGenerators#179 so the published contract matches the runtime. Only the binding converter page changes.
Checklist