arm64: dts: qcom: shikra: Add PMIC thermal and ADC support#888
arm64: dts: qcom: shikra: Add PMIC thermal and ADC support#888kotarake wants to merge 1 commit intoqualcomm-linux:early/hwe/shikra/dtfrom
Conversation
Komal-Bajaj
force-pushed
the
early/hwe/shikra/dt
branch
from
74255bb to
16980ad
Compare
kotarake
force-pushed
the
shikra-dt
branch
3 times, most recently
from
bcde924 to
a057960
Compare
| }; | ||
|
|
||
| channel@2a { | ||
| reg = <ADC5_BAT_THERM_30K_PU>; |
There was a problem hiding this comment.
You can remove the channels with these channel numbers:
ADC5_BAT_THERM_30K_PU
ADC5_BAT_THERM_100K_PU
ADC5_BAT_THERM_400K_PU
ADC5_PARALLEL_ISENSE
Because these are not present in the mapping table in the ADC driver I see upstream, so their scaling functions will not be supported right now.
| pm8005_tz: temp-alarm@2400 { | ||
| compatible = "qcom,spmi-temp-alarm"; | ||
| reg = <0x2400>; | ||
| interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_BOTH>; |
There was a problem hiding this comment.
update in next patch
| }; | ||
|
|
||
| &pm4125_resin { | ||
| linux,code = <KEY_VOLUMEUP>; |
There was a problem hiding this comment.
update in next patch-set
| gpios = <&pm4125_gpios 9 GPIO_ACTIVE_LOW>; | ||
| linux,input-type = <1>; | ||
| linux,code = <KEY_VOLUMEUP>; | ||
| gpio-key,wakeup; |
There was a problem hiding this comment.
I think "gpio-key,wakeup" does not exist.....should this be wakeup-source ?
There was a problem hiding this comment.
update in next patch-set
| pinctrl-names = "default"; | ||
|
|
||
| channel@56 { | ||
| reg = <ADC5_GPIO5_100K_PU>; |
There was a problem hiding this comment.
GPIOs 5 and 6 of Cocos have channel numbers 0x54 and 0x55, which are ADC5_GPIO3_100K_PU and ADC5_GPIO4_100K_PU
There was a problem hiding this comment.
update in next patch-set
| }; | ||
|
|
||
| &pm8150_adc_tm { | ||
| status = "okay"; |
There was a problem hiding this comment.
Check the indentation for this line
| sys-therm-3 { | ||
| polling-delay-passive = <2000>; | ||
| polling-delay = <0>; | ||
| thermal-sensors = <&pm8150_adc_tm 3>; |
There was a problem hiding this comment.
Should this be <&pm8150_adc_tm 2>; ? Because the adctm reg properties above have values 0, 1 and 2.
There was a problem hiding this comment.
update in next patch-set
|
|
||
| &thermal_zones { | ||
| sys-therm-1 { | ||
| polling-delay-passive = <2000>; |
There was a problem hiding this comment.
Is this polling delay value correct? I think it is not needed for ADC_TM thermistors
There was a problem hiding this comment.
removed the polling delay values
|
|
||
| pa-therm@0 { | ||
| reg = <0>; | ||
| io-channels = <&pm8150_adc ADC5_GPIO4_100K_PU>; |
There was a problem hiding this comment.
There is an extra space between &pm8150_adc and ADC5_GPIO4_100K_PU, remove it
|
|
||
| &pm4125_gpios { | ||
| key_vol_up { | ||
| key_vol_up_default: key_vol_up_default { |
There was a problem hiding this comment.
node_label: node-name
no underscores in node name.
| }; | ||
|
|
||
| adc_gpio5 { | ||
| pm4125_adc_gpio5_default: pm4125_adc_gpio5_default { |
There was a problem hiding this comment.
node_label: node-name
no underscores in node name.
| }; | ||
|
|
||
| adc_gpio6 { | ||
| pm4125_adc_gpio6_default: pm4125_adc_gpio6_default { |
There was a problem hiding this comment.
node_label: node-name
no underscores in node name.
| #thermal-sensor-cells = <0>; | ||
| }; | ||
|
|
||
| pm4125_vadc: vadc@3100 { |
There was a problem hiding this comment.
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dtb: pmic@0 (qcom,pm2250): 'vadc@3100' does not match any of the regexes: '(.*)?(wled|leds)@[0-9a-f]+$', '^adc-tm@[0-9a-f]+$', '^adc@[0-9a-f]+$', '^audio-codec@[0-9a-f]+$', '^battery@[0-9a-f]+$', '^charger@[0-9a-f]+$', '^led-controller@[0-9a-f]+$', '^mpps@[0-9a-f]+$', '^nvram@[0-9a-f]+$', '^pbs@[0-9a-f]+$', '^pinctrl-[0-9]+$', '^rtc@[0-9a-f]+$', '^temp-alarm@[0-9a-f]+$', '^typec@[0-9a-f]+$', '^usb-detect@[0-9a-f]+$', '^usb-vbus-regulator@[0-9a-f]+$', '^vibrator@[0-9a-f]+$', 'gpio@[0-9a-f]+$', 'phy@[0-9a-f]+$', 'pon@[0-9a-f]+$'
pm4125_vadc: adc@3100 {
| /* APQ (No Modem), Cocos + Kunlun PMIC */ | ||
|
|
||
| &pm4125_gpios { | ||
| key_vol_up { |
There was a problem hiding this comment.
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml#
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dtb: gpio_key (gpio-keys): 'vol_up' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', '^pinctrl-[0-9]+$'
key-volume-up
| }; | ||
| }; | ||
|
|
||
| pm4125_pa_therm_bridge: pm4125_pa_therm_bridge { |
There was a problem hiding this comment.
nodes in soc@0: 'ranges' is a required property (simple-bus schema). These generic-adc-thermal nodes are placed directly under &soc which is a simple-bus, schema requires ranges. Fix either add ranges, to the nodes or place them outside the simple-bus scope.
| }; | ||
| }; | ||
|
|
||
| pm4125_tz: temp-alarm@2400 { |
There was a problem hiding this comment.
Fix node address ordering -- reorder usb-vbus-regulator@1100 before the new nodes
| qcom,pre-scaling = <1 1>; | ||
| }; | ||
|
|
||
| channel@4d { |
There was a problem hiding this comment.
Please arrange the ADC nodes also based on node address order here and in other places
Add PMIC topic overlay changes for Shikra SOM variants (CQM, CQS, IQS): - Add pm4125 temp-alarm and VADC channel nodes - Add pm8005 temp-alarm node - Add thermal zones for PMIC and system thermistors - Add GPIO key (volume up) bindings - Add ADC thermal bridge nodes for pa/quiet/msm thermistors - Disable pm8005 regulators across SOM variants - Switch SPMI interrupt to MPM edge-triggered Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
3 participants
Add PMIC topic overlay changes for Shikra SOM variants (CQM, CQS, IQS):