Skip to content

Expose independent sides for slot sizes - #2228

Merged
pzfreo merged 1 commit into
fix/2211-pocket-callout-sidefrom
fix/2211-slot-dimension-side
Oct 7, 2026
Merged

pzfreo merged 1 commit into
fix/2211-pocket-callout-sidefrom
fix/2211-slot-dimension-side

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Part of #2211. Expose side controls for slot width and length, with valid sides derived from each dimension’s projected measured axis. Each linear mark keeps its own side policy; an explicit request cannot fall back to the opposite strip. Shared-width grouping now respects side policy. Includes XY and upright-axis option tests plus real drawing placements; source-shape baselines are lowered after extracting the shared chooser. Local checks: affected side tests, source-shape guard, lint/format/mypy/docs. Stacked on #2227; merge atomically with stack #2229 only when every required check is green.

@pzfreo

pzfreo commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner Author

Focused local coverage preflight against the stacked parent: 44 changed source lines, 42 covered (95%). The two uncovered lines are the envelope unsupported-view refusal and a renderer invariant guard for an impossible slot side. Source-shape, static/docs, and new real slot placements pass locally; the full CI suite is still pending.

@pzfreo
pzfreo force-pushed the fix/2211-slot-dimension-side branch from 0021aed to cf7f91b Compare October 7, 2026 02:01
@pzfreo
pzfreo force-pushed the fix/2211-slot-dimension-side branch from cf7f91b to 321b8ee Compare October 7, 2026 03:51
@pzfreo
pzfreo added this pull request to stack #2229 October 7, 2026 03:52
@pzfreo
pzfreo merged commit a561daa into main Oct 7, 2026
19 of 29 checks passed
@pzfreo
pzfreo deleted the fix/2211-slot-dimension-side branch October 7, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant