Repository navigation
Expose independent sides for slot sizes - #2228
Merged
Merged
Conversation
Owner
Author
|
Focused local coverage preflight against the stacked parent: 44 changed source lines, 42 covered (95%). The two uncovered lines are the envelope unsupported-view refusal and a renderer invariant guard for an impossible slot side. Source-shape, static/docs, and new real slot placements pass locally; the full CI suite is still pending. |
pzfreo
force-pushed
the
fix/2211-slot-dimension-side
branch
from
October 7, 2026 02:01
0021aed to
cf7f91b
Compare
pzfreo
force-pushed
the
fix/2211-slot-dimension-side
branch
from
October 7, 2026 03:51
cf7f91b to
321b8ee
Compare
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2211. Expose side controls for slot width and length, with valid sides derived from each dimension’s projected measured axis. Each linear mark keeps its own side policy; an explicit request cannot fall back to the opposite strip. Shared-width grouping now respects side policy. Includes XY and upright-axis option tests plus real drawing placements; source-shape baselines are lowered after extracting the shared chooser. Local checks: affected side tests, source-shape guard, lint/format/mypy/docs. Stacked on #2227; merge atomically with stack #2229 only when every required check is green.