Skip to content

Expose side controls for authored PMI dimensions (#2211) - #2218

Merged
pzfreo merged 1 commit into
fix/2211-slot-dimension-sidefrom
fix/2211-authored-pmi-side
Oct 7, 2026
Merged

pzfreo merged 1 commit into
fix/2211-slot-dimension-sidefrom
fix/2211-authored-pmi-side

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #2228 in GitHub stack #2229; partial #2211. Source-authored measured dimensions already render declared side intent, but layout_options hid side whenever the current value was unset. Discover renderer-compatible sides from the existing IR placement validator, and refuse dimension kinds the renderer cannot draw. The generated script, declared model, rendered label corridor, and report all retain the edit. No raw coordinates.

Local: 38 focused layout/source-shape tests, 11 architecture/routing checks, targeted mypy/Ruff, strict docs build, and 100% changed-line coverage. The real Sheet test verifies an unset linear PMI dimension moves below its front view and replays.

Base automatically changed from fix/2211-editor-dimension-side to main October 7, 2026 02:50
@pzfreo
pzfreo force-pushed the fix/2211-authored-pmi-side branch from 6fceb80 to 333c9f4 Compare October 7, 2026 03:51
@pzfreo
pzfreo changed the base branch from main to fix/2211-slot-dimension-side October 7, 2026 03:51
@pzfreo
pzfreo added this pull request to stack #2229 October 7, 2026 03:52
@pzfreo
pzfreo merged commit c3b24b9 into main Oct 7, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/2211-authored-pmi-side branch October 7, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant