Repository navigation
Expose side controls for authored PMI dimensions (#2211) - #2218
Merged
Merged
Conversation
pzfreo
force-pushed
the
fix/2211-authored-pmi-side
branch
from
October 7, 2026 03:51
6fceb80 to
333c9f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2228 in GitHub stack #2229; partial #2211. Source-authored measured dimensions already render declared side intent, but layout_options hid side whenever the current value was unset. Discover renderer-compatible sides from the existing IR placement validator, and refuse dimension kinds the renderer cannot draw. The generated script, declared model, rendered label corridor, and report all retain the edit. No raw coordinates.
Local: 38 focused layout/source-shape tests, 11 architecture/routing checks, targeted mypy/Ruff, strict docs build, and 100% changed-line coverage. The real Sheet test verifies an unset linear PMI dimension moves below its front view and replays.