Repository navigation
Expose bounded sides for pocket callouts - #2227
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Owner
Author
|
Focused local changed-line coverage against the stacked parent: 12 coverable changed source lines, all covered (100%) by the four real-pocket side placements and width-control refusal. Source-shape, static/docs, and focused pocket regressions also pass locally. Full CI remains pending. |
pzfreo
force-pushed
the
fix/2211-pocket-callout-side
branch
from
October 7, 2026 02:01
734df45 to
92980b9
Compare
pzfreo
force-pushed
the
fix/2211-pocket-callout-side
branch
from
October 7, 2026 03:51
92980b9 to
ca69844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2211. Advertise the four bounded side controls for declared pocket dimensions, carry the requested side through the compiler-approved pocket leader job, and restrict candidate rays to the chosen hemisphere. The shared placement solve still decides exact geometry and reports infeasible placements rather than silently moving sides. Includes real A3 pocket tests for all four sides and reference documentation. Local checks: focused pocket tests (27 passed), source-shape guard (7 passed),
scripts/pr-check --static(lint, format, mypy, docs). Stacked on #2226; merge atomically with stack #2229 only when every required check is green.