Skip to content

Expose bounded sides for pocket callouts - #2227

Merged
pzfreo merged 2 commits into
fix/2211-boss-diameter-sidefrom
fix/2211-pocket-callout-side
Oct 7, 2026
Merged

pzfreo merged 2 commits into
fix/2211-boss-diameter-sidefrom
fix/2211-pocket-callout-side

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Part of #2211. Advertise the four bounded side controls for declared pocket dimensions, carry the requested side through the compiler-approved pocket leader job, and restrict candidate rays to the chosen hemisphere. The shared placement solve still decides exact geometry and reports infeasible placements rather than silently moving sides. Includes real A3 pocket tests for all four sides and reference documentation. Local checks: focused pocket tests (27 passed), source-shape guard (7 passed), scripts/pr-check --static (lint, format, mypy, docs). Stacked on #2226; merge atomically with stack #2229 only when every required check is green.

@pzfreo

pzfreo commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

Focused local changed-line coverage against the stacked parent: 12 coverable changed source lines, all covered (100%) by the four real-pocket side placements and width-control refusal. Source-shape, static/docs, and focused pocket regressions also pass locally. Full CI remains pending.

@pzfreo
pzfreo force-pushed the fix/2211-pocket-callout-side branch from 734df45 to 92980b9 Compare October 7, 2026 02:01
@pzfreo
pzfreo force-pushed the fix/2211-pocket-callout-side branch from 92980b9 to ca69844 Compare October 7, 2026 03:51
@pzfreo
pzfreo added this pull request to stack #2229 October 7, 2026 03:52
@pzfreo
pzfreo merged commit 115d8b5 into main Oct 7, 2026
19 of 29 checks passed
@pzfreo
pzfreo deleted the fix/2211-pocket-callout-side branch October 7, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant