Skip to content

Keep full strip annotation ink inside the sheet (rc8 PMI) - #2191

Merged
pzfreo merged 3 commits into
mainfrom
fix/rc8-pmi-placement
Oct 5, 2026
Merged

pzfreo merged 3 commits into
mainfrom
fix/rc8-pmi-placement

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Closes #2189 and #2190.

The shared strip solve bounded the assigned dimension-line coordinate but did not validate the complete built annotation. A nearly horizontal authored 60 dimension routed to the left strip, extending its witness lines 667 mm below the drawable A1 sheet. That invalid ink then occupied the front-view placement area and caused authored 35 and 85 locations to drop.

Reject a built strip survivor whose full box leaves the drawable sheet, including force fallbacks; return it to the existing placement/drop path. This is a general strip-candidate guard, not a special case for the fixture.

Evidence: the public Specify plate gist linked in both issues reproduces all three symptoms on rc8 at explicit A1, 1:2. With this patch, no annotation_out_of_bounds remains; 35 and 85 are placed as authored PMI; 60 is reported as pmi_dropped instead of drawn off-sheet. The missing 75 +0.1/0 dimension predates rc8 and is not claimed fixed here. A focused synthetic nearly parallel PMI guard fails when the page-box check is removed and passes with it. Eight focused strip tests and scripts/pr-check --static pass. No slow suite was rerun locally.

ADR fit: the check stays inside ADR 2 shared placement, preserves ADR 1 one-engine staging and ADR 3 recognition, changes no ADR 4 authored content, and keeps ADR 5 honest named-drop reporting. No ADR boundary changes.

@pzfreo
pzfreo merged commit db3b053 into main Oct 5, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/rc8-pmi-placement branch October 5, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rc8: an authored AP242 dimension placed far outside the sheet (annotation_out_of_bounds, 667 mm below)

1 participant