Repository navigation
Keep full strip annotation ink inside the sheet (rc8 PMI) - #2191
Merged
Merged
Conversation
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2189 and #2190.
The shared strip solve bounded the assigned dimension-line coordinate but did not validate the complete built annotation. A nearly horizontal authored 60 dimension routed to the left strip, extending its witness lines 667 mm below the drawable A1 sheet. That invalid ink then occupied the front-view placement area and caused authored 35 and 85 locations to drop.
Reject a built strip survivor whose full box leaves the drawable sheet, including force fallbacks; return it to the existing placement/drop path. This is a general strip-candidate guard, not a special case for the fixture.
Evidence: the public Specify plate gist linked in both issues reproduces all three symptoms on rc8 at explicit A1, 1:2. With this patch, no annotation_out_of_bounds remains; 35 and 85 are placed as authored PMI; 60 is reported as pmi_dropped instead of drawn off-sheet. The missing 75 +0.1/0 dimension predates rc8 and is not claimed fixed here. A focused synthetic nearly parallel PMI guard fails when the page-box check is removed and passes with it. Eight focused strip tests and scripts/pr-check --static pass. No slow suite was rerun locally.
ADR fit: the check stays inside ADR 2 shared placement, preserves ADR 1 one-engine staging and ADR 3 recognition, changes no ADR 4 authored content, and keeps ADR 5 honest named-drop reporting. No ADR boundary changes.