Skip to content

Extract Sheet identity and layout-control owners (#1955) - #1992

Merged
pzfreo merged 9 commits into
mainfrom
epic1939/1955_sheet_layout_private
Sep 28, 2026
Merged

pzfreo merged 9 commits into
mainfrom
epic1939/1955_sheet_layout_private

Conversation

@pzfreo

@pzfreo pzfreo commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Move Sheet's token-preserving feature view into sheet_features.py, retaining the private _FeatureView import alias and list identity behavior.
  • Move declaration ID lookup and bounded side/lane layout-control policy into sheet_layout_controls.py, preserving Sheet's public methods and input validation.
  • Reduce sheet.py from 3,860 to 3,533 lines. Keep both owners at facade rank 7, update the architecture and agent maps, and select the new layout-control owner's declaration contract in the PR tier.

This is a behavior-preserving slice of #1955. The module remains over the epic's 3,000-line exit limit.

Verification

  • Fresh independent review of the final rebased branch found no remaining P0-P3 findings after the PR-tier selection was corrected.
  • Static checks pass; 444 Sheet/identity/golden/manifest tests and 440 tests from the actual fast side/lane/identity/declaration selection pass on the rebased branch.
  • Changed-line coverage is 98% (174/177), with 100% on sheet_layout_controls.py.
  • The refactor golden corpus and all 18 script-detail parity tests pass on this branch after rebasing onto main with Consolidate test health and repair table failure tests (#1935) #1981.

Refs #1955. Refs #1939.

@pzfreo
pzfreo enabled auto-merge (squash) September 28, 2026 20:51
@pzfreo
pzfreo merged commit be7ed29 into main Sep 28, 2026
19 checks passed
@pzfreo
pzfreo deleted the epic1939/1955_sheet_layout_private branch September 28, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant