Skip to content

Extract Sheet view declarations and meet module limit - #1996

Merged
pzfreo merged 2 commits into
mainfrom
epic1939/1955_sheet_finish
Sep 28, 2026
Merged

pzfreo merged 2 commits into
mainfrom
epic1939/1955_sheet_finish

Conversation

@pzfreo

@pzfreo pzfreo commented Sep 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move whole-view declarations and constraints from the Sheet facade into the focused rank-7 sheet_views.py owner.
  • Reduce sheet.py from 3,533 to 2,922 physical lines, meeting its Code health: shrink the eight remaining source modules over 3,000 lines #1955 module limit. All 78 public Sheet method names remain available.
  • Keep runtime-resolvable fluent return hints and render inherited public view methods in the Sheet API reference. Update import layer, architecture, and agent maps. No ADR wording changes.

Verification

  • Fresh independent P0–P3 review found two P2 regressions in the first commit (API reference and runtime type hints). Both were fixed and independently re-reviewed clean.
  • Static checks pass. Pre-rebase golden, script parity, identity, and import checks: 772 passed, 1 expected xfail; additional focused runs: 315, 235, 166, and 63 passed. After replaying onto merged Extract Sheet identity and layout-control owners (#1955) #1992, static and 200 focused API/identity/import checks pass.
  • Changed-line coverage of the completed branch is 94%. A mutation of the source-location guard made its regression test fail as intended.

Refs #1955. Refs #1939.

@pzfreo
pzfreo enabled auto-merge (squash) September 28, 2026 21:26
@pzfreo
pzfreo force-pushed the epic1939/1955_sheet_finish branch from 4ea5e4d to 88c81b5 Compare September 28, 2026 21:46
@pzfreo
pzfreo merged commit 911e93b into main Sep 28, 2026
19 checks passed
@pzfreo
pzfreo deleted the epic1939/1955_sheet_finish branch September 28, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant