Skip to content

Consolidate test health and repair table failure tests (#1935) - #1981

Merged
pzfreo merged 4 commits into
mainfrom
epic1939/1935-test-health
Sep 28, 2026
Merged

pzfreo merged 4 commits into
mainfrom
epic1939/1935-test-health

Conversation

@pzfreo

@pzfreo pzfreo commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Fold two zone-label ink regressions into their behavior-owned lint module and lower the issue-named test cap from 151 to 150.
  • Share one filleted drawing across three read-only declaration tests through a class-scoped fixture; the selected three-node median fell from 2.959 to 2.319 seconds locally.
  • Repair seven stale baseline tests at their current seams: three hole-table fit tests, reserved-box detail redraw, step inspection's current pinned modules, the obligation message assertion, and trace candidate fixture state. The table tests assert that fitting ran, the table dropped, and semantic fallback outcomes remain nonempty.

All changes are test-only; no production or ADR behavior changes.

Verification

  • Fresh independent review of the four-commit combined diff found no P0-P3 issues.
  • Static checks and 295 focused tests passed. The seven repaired tests failed on untouched main and pass on this branch.
  • A 16-worker full-suite audit on main 82a86b70 found 9,727 pass, 19 fail, 3 error; all 22 failing/error IDs matched the recorded baseline. The audit and triage are recorded on Code health: shrink test_issue_* modules, close the clone-budget pair gap, share build fixtures #1935. The normal required PR CI gate is used while unrelated baseline issues are resolved separately.

Refs #1935. Refs #1939.

@pzfreo pzfreo added the full-matrix Run the full cross-platform CI matrix on this PR label Sep 28, 2026
@pzfreo
pzfreo marked this pull request as ready for review September 28, 2026 18:19
@pzfreo
pzfreo enabled auto-merge (squash) September 28, 2026 18:19
@pzfreo
pzfreo force-pushed the epic1939/1935-test-health branch 2 times, most recently from fcb50dc to 8207e14 Compare September 28, 2026 18:39
@pzfreo pzfreo removed the full-matrix Run the full cross-platform CI matrix on this PR label Sep 28, 2026
@pzfreo pzfreo changed the title Reduce issue-named tests and reuse fillet drawing Consolidate test health and repair table failure tests (#1935) Sep 28, 2026
@pzfreo
pzfreo force-pushed the epic1939/1935-test-health branch from 8207e14 to d57fb46 Compare September 28, 2026 20:19
@pzfreo
pzfreo merged commit 4ab7e74 into main Sep 28, 2026
18 checks passed
@pzfreo
pzfreo deleted the epic1939/1935-test-health branch September 28, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant