Skip to content

[executorch][native-ggml] Reject weight-only quantized linears unless activation quant is allowed - #24361

Open
digantdesai wants to merge 4 commits into
gh/digantdesai/188/basefrom
gh/digantdesai/188/head
Open

digantdesai wants to merge 4 commits into
gh/digantdesai/188/basefrom
gh/digantdesai/188/head

Conversation

@digantdesai

@digantdesai digantdesai commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

ggml quantizes the activations of its quantized matmuls, so weight-only int4 and GGUF linears silently ran with numerics the PTN doesn't describe. Compile now rejects them unless GgmlEngineOptions::allow_activation_quant_for_weight_only is set. ggml_ptn_runner and run_hf_llm_ggml expose it as --allow_activation_quant_for_weight_only, which GGUF LLMs on ggml now need.

Authored with Claude Code.

@bypass-github-export-checks
@bypass-github-pytorch-ci-checks
@bypass-github-executorch-ci-checks
@exported-using-ghexport

Differential Revision: D128254887

Differential Revision: D128254887

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24361

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 9a2c229 with merge base 0f8e096 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2026
This was referenced Oct 30, 2026

@SS-JIA SS-JIA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]

This branch was previously deployed

1 inactive deployment
cadence — 9a2c229a Deployed Nov 3, 2026 by digantdesai via hifi-op-test / hifi4 #36239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants