Repository navigation
Conversation
…on inlined Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHJ728Kwktcff5BR2sx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHJ728Kwktcff5BR2sx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHJ728Kwktcff5BR2sx
Member
Author
|
Replaced by #4756: the same change restacked onto #4754 (which replaced #4732), with the benchmark results. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4141 (PPC64LE audit, finding 1). Stacked on #4732, so it stays a draft until that merges.
P-521's
[d]Gand[k]Gon PPC64LE used the Montgomery ladder. #4729's comb needs the point functions' slots, which fit at most 6 words, and P-521 has 9.What changes
Impl/Weierstrass/PPC64LE/TCombI.lean: the comb for coordinates of more than 6 words, on the ladder's layout, as the ladder runs them (ladder). It keeps the comb's window, digit, scan and sign (TComb.lean).T.R = R + Tis the complete addition inlined (rcb, calls of the field's functions) into the ladder'sD, then copied toR.TCombCfggainsqBase, where the entry goes. Its default is the point functions'Q, so the existing combs are unchanged; theirLayoutgainsqAt := rfl.Proof/Weierstrass/PPC64LE/TCombI.lean:combI_okprovesR = [k]G, reduced, changing onlypowCloband the ladder's writes (ladWx).LayoutIandConfigIhold the side conditions: the ladder'sLadLayI, the entry inT,-yinD.x, zero apart from what the ladder writes,RcbApart S R T D.TComb.lean's digit, scan, select and sign lemmas.entryI_okandnegateI_okfollowentry_okandnegate_okon this layout.addI_genisrcb_okthencopyPt_ok.Impl/Ecdsa/P521/PPC64LEComb.lean,Proof/P521/PPC64LE/Comb.lean, and the public-key, signature and RFC 6979 files, as for P-256):Impl/P521/CombTable7.lean): 83 windows of seven bits over the ladder's table of all 576 bits of the scalar.Verifiedare deleted.VG_P521_COMBnot to be one of the HMAC table's function names.No TCB or Spec change.
Testing
lake buildandEmit.leanpass on this tree. The only crate changes are P-521's, incrates/verified-garbage-asm-powerpc64le(ec_p521,internal/vg_ecdsa_p521_sign_k, and the newconsts/vg_p521_comb.rs).check_lean_public_imports.pypass.Benchmark
A Benchmarks run is queued, scoped to
arches=powerpc64,modules=ec_p521,ecdsa_p521,groups=ec_p521_public_key,ecdsa_p521_sha512_sign, with base 3ae8b0e (#4732's head). I'll add the link and results here.Generated by Claude Code