Repository navigation
Conversation
brainpoolP256r1's and brainpoolP384r1's seven-bit combs (37 and 55 windows, the other targets' tables, `Impl/<Curve>/CombTable7.lean`) on PPC64LE's generic comb, as P-384's (#4700): `[d]G` for `vg_ec_<curve>_public_key` and `[k]G` for `vg_ecdsa_<curve>_sign_k`, whose RFC 6979 signature passes the comb's table. The ladder's public keys and signatures, their literals and their `Verified` are gone. `Proof/<Curve>/Comb7Shape.lean` proves the tables' shape once, with no target. The crates follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHFbSpgWBYWAsEnfUks
The public keys' and signatures' code, and the combs' tables
(`consts/vg_brainpoolp{256,384}r1_comb.rs`), from the full emitter. The
tables' shape modules say why they are separate.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TKUFHFbSpgWBYWAsEnfUks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHFbSpgWBYWAsEnfUks
This was referenced Nov 8, 2026
Member
Author
|
Replaced by #4768, the same change restacked onto #4754 ( Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4141 (the PPC64LE audit). Replaces #4711, restacked onto #4732 (which replaced #4688). This PR's two commits are cherry-picked unchanged, and the rebuild and full emit of the new base gave the same crate. It stays a draft until #4732 merges.
On PPC64LE,
[d]G(public keys) and[k]G(RFC 6979 signatures) for brainpoolP256r1 and brainpoolP384r1 used the Montgomery ladder, one double, add and select per bit. They now use the fixed-base signed seven-bit comb of #4675 (Impl/Weierstrass/PPC64LE/TComb.lean), as P-256 and P-384 do.brainpoolP512r1 will follow, on the widened comb for P-521 (#4736).
What changes
The per-curve files are P-384's with the curve's names and sizes. Nothing shared changes: TComb, the RFC 6979 wrapper, the README tables, the dispatch and the variants all stay as they are.
Impl/Ecdsa/<Curve>/PPC64LEComb.lean: the comb's configuration, built on the curve's ladder layout, with the other targets' tables (Impl/<Curve>/CombTable7.lean, with 37 and 55 windows). AlsopublicKey<Curve>Combandsign<Curve>Comb.Proof/<Curve>/PPC64LE/Comb.lean: the layout andConfig, the table's words, andcomb_generator_ok, i.e. the comb as the stages' generator. The complete addition takesafrom memory, so brainpool'sa ≠ −3needs nothing special.Proof/<Curve>/Comb7Shape.lean(new, target-independent): the tables' length and rows, asProof/P384/Comb7Shape.lean.Proof/EcKey/PPC64LE/<Curve>/Comb{,Lit}.leanandProof/Ecdsa/PPC64LE/<Curve>/Comb{,Lit}.lean: correctness, constant time (taint_decide, with the table's address public) andVerified, with the table as a constant (Abi.withConsts).cs), and the registration requires thatVG_<CURVE>_COMBis not one of the HMAC table's names.Verified. Nothing else used them.No TCB, Spec or Rust change. The crate changes are
crates/verified-garbage-asm-powerpc64leonly: the two curves' modules,internal/vg_ecdsa_<curve>_sign_k, and the newconsts/vg_<curve>_comb.rs.Testing
Emit.leanpasses with nothing to commit beyond the two commits. The Static checks pass.Benchmark
Measured on #4711, whose code this is: Benchmarks run 42519119906, with
arches=powerpc64, the two curves' public-key and signing groups, and base8c69d0ca(#4688's head, the same comb code as #4732).ec_brainpoolp256r1_public_key/65ec_brainpoolp384r1_public_key/97ecdsa_brainpoolp256r1_sha256_sign/64ecdsa_brainpoolp256r1_sha256_sign/1024ecdsa_brainpoolp256r1_sha256_sign/16384ecdsa_brainpoolp384r1_sha384_sign/64ecdsa_brainpoolp384r1_sha384_sign/1024ecdsa_brainpoolp384r1_sha384_sign/16384The signing groups were noisy on that runner (the job flagged spreads of 12–93%), but every group is faster, by 58–84%.
Generated by Claude Code