Repository navigation
TCB: delete Emit.qualifiedName - #4706
Merged
Merged
Conversation
alex
force-pushed
the
claude/vg-qualified-name
branch
from
November 8, 2026 20:43
ba3b8f6 to
f5872b5
Compare
alex
force-pushed
the
claude/vg-tcb-no-qualified-name
branch
from
November 8, 2026 20:43
36ec3a2 to
212a532
Compare
alex
force-pushed
the
claude/vg-qualified-name
branch
from
November 8, 2026 21:22
f5872b5 to
94a83d7
Compare
alex
force-pushed
the
claude/vg-tcb-no-qualified-name
branch
from
November 8, 2026 21:22
212a532 to
7017272
Compare
alex
force-pushed
the
claude/vg-qualified-name
branch
from
November 8, 2026 21:46
94a83d7 to
1f5bcc6
Compare
alex
force-pushed
the
claude/vg-tcb-no-qualified-name
branch
from
November 8, 2026 21:46
7017272 to
915788b
Compare
alex
force-pushed
the
claude/vg-qualified-name
branch
from
November 8, 2026 22:01
1f5bcc6 to
1e8487f
Compare
alex
force-pushed
the
claude/vg-tcb-no-qualified-name
branch
from
November 8, 2026 22:01
915788b to
0a60d26
Compare
Nothing in the trusted base uses it since the dispatchers stopped parsing names to rank implementations; the registration files name instances with the untrusted copy in `Proof/Framework/QualifiedName.lean`. Part of #4548. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHFjAR7Byf513R4zuFy
alex
force-pushed
the
claude/vg-tcb-no-qualified-name
branch
from
November 8, 2026 22:27
0a60d26 to
4153c78
Compare
alex
enabled auto-merge
November 8, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4548. This is stacked on #4703. This PR changes trusted code, but only to delete it.
TCB/Emit.lean'squalifiedNameis deleted. Nothing in the trusted base has used it since #4685, when dispatchers stopped parsing names to rank implementations. Since #4703, registration files name their instances with the untrusted copy inProof/Framework/QualifiedName.lean. Theadding-a-primitiveskill now points to that copy.The generated crates are unchanged:
Emit.lean --checkpasses, and so dolake buildand every step of the Static checks job.Generated by Claude Code