Repository navigation
qualifiedName is a registration helper, not part of the emitter - #4703
Merged
Merged
Conversation
alex
force-pushed
the
claude/vg-sha-compress-lists
branch
from
November 8, 2026 20:43
7dfa4ee to
c74fcdc
Compare
alex
force-pushed
the
claude/vg-qualified-name
branch
from
November 8, 2026 20:43
ba3b8f6 to
f5872b5
Compare
alex
force-pushed
the
claude/vg-sha-compress-lists
branch
from
November 8, 2026 21:22
c74fcdc to
bdbaba0
Compare
alex
force-pushed
the
claude/vg-qualified-name
branch
from
November 8, 2026 21:22
f5872b5 to
94a83d7
Compare
alex
force-pushed
the
claude/vg-sha-compress-lists
branch
from
November 8, 2026 21:46
bdbaba0 to
f54c962
Compare
alex
force-pushed
the
claude/vg-qualified-name
branch
from
November 8, 2026 21:46
94a83d7 to
1f5bcc6
Compare
The names of a generic caller's instances (`qualifiedName`: the function's name, then a tag and the suffix of each interface whose variant is not the baseline) were defined in the trusted base, for the emitter, which parsed them back to rank the instances. It no longer does: the dispatchers try them in the order their registration file lists them. Define the helper in `Proof/Framework/QualifiedName.lean`, with its tests, and use that (the trusted definition goes in a change of its own). Naming is not trusted: the emitter checks that every name is unique. The generated crates are unchanged. Part of #4548. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHFjAR7Byf513R4zuFy
alex
force-pushed
the
claude/vg-qualified-name
branch
from
November 8, 2026 22:01
1f5bcc6 to
1e8487f
Compare
alex
enabled auto-merge
November 8, 2026 22:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4548. This is stacked on #4696. There are no trust changes here; the follow-up PR deletes the trusted copy.
Emit.qualifiedNamenames a generic caller's instances: the function's name, then a tag and the suffix of each interface whose variant is not the baseline. It lived in the trusted base because the emitter used to parse those names back to rank the instances. Since #4685 it no longer does: dispatchers try implementations in the order their registration file lists them.What changes
Proof/Framework/QualifiedName.leanasVG.qualifiedName.VerifiedGarbageTest/QualifiedName.lean.Naming is not trusted: the emitter checks that every name is unique (
Rust.checkUnique). The generated crates are unchanged.Checks
lake buildpasses.Emit.lean --checkpasses.check_lean_public_imports.pypasses.Generated by Claude Code