Repository navigation
TML-3439: A product release releases the CLI, so prisma@latest never pins an older ORM toolchain #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wmadden-electric
wants to merge
3
commits into
main
Choose a base branch
from
follow-releases-ship-the-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TML-3439: A product release releases the CLI, so prisma@latest never pins an older ORM toolchain #384
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
ed1c346
A product release releases the CLI: the version-follow pull request a…
wmadden-electric 872217c
Release main's product pins when no release shipped them
wmadden-electric 96285fb
Compare with the registry alone while the last release has no tag yet
wmadden-electric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: prisma/prisma-cli
Length of output: 16020
Qualify the "no person in the loop" guarantee so it matches the approval step.
Step 4 merges the release pull request only after CodeRabbit approves it. The troubleshooting table says a maintainer approves the pull request by hand when that approval does not arrive. The sentence on line 22 says a product release reaches a released CLI with no person in the loop. Limit that sentence to the normal path and state the manual fallback.
Suggested fix
Committable suggestion