Lazify pat-querystring: split registration from implementation#1613
Open
MrTango wants to merge 1 commit into
Open
Lazify pat-querystring: split registration from implementation#1613MrTango wants to merge 1 commit into
MrTango wants to merge 1 commit into
Conversation
Member
|
/run-coredev-6.3-robottests |
petschki
force-pushed
the
mockup-lazy-querystring
branch
from
July 17, 2026 08:06
0abaf74 to
cea64e8
Compare
…entation pat-querystring contributed ~33KB src to the eager patterns chunk on every page, though the widget only appears on Collection edit forms and the querystring criteria UI. It also statically imported the contentbrowser pattern, dragging an eager edge into pat-contentbrowser. Split it into a thin registration module and querystring--implementation.js (holding the widget and the contentbrowser import). The implementation is grafted onto the single pattern instance in init(), so external consumers that reach into instance state (pat-structure's textfilter reads this.queryString.$sortOn/$sortOrder) keep working. Public options and emitted markup are unchanged. The implementation and its contentbrowser edge now load only on pages with a .pat-querystring element.
petschki
force-pushed
the
mockup-lazy-querystring
branch
from
July 17, 2026 08:11
cea64e8 to
8f166a1
Compare
petschki
approved these changes
Jul 17, 2026
petschki
left a comment
petschki
left a comment
Member
There was a problem hiding this comment.
LGTM!
I've changed the commit message to align it with conventionals commit log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pat-querystring contributed ~33KB src to the eager patterns chunk on every page, though the widget only appears on Collection edit forms and the querystring criteria UI. It also statically imported the contentbrowser pattern, dragging an eager edge into pat-contentbrowser.
Split it into a thin registration module and querystring--implementation.js (holding the widget and the contentbrowser import).
addresses #1618