Lazify pat-recurrence: split registration from implementation#1614
Merged
Conversation
This was referenced Jul 13, 2026
Merged
petschki
force-pushed
the
mockup-lazy-recurrence
branch
from
July 17, 2026 08:51
a872ede to
3fe5eb5
Compare
Member
|
/run-coredev-6.3-robottests |
…ntation pat-recurrence was the single largest pattern in the eager patterns chunk (~52KB src, incl. three statically-imported XML templates and the Modal dependency), loaded on every page though the widget only appears on Event add/edit forms. Split it into a thin registration module (trigger, parser, and an init() that dynamically imports the implementation on first match) plus recurrence--implementation.js holding the widget, the XML templates and the Modal import. Follows the existing tinymce--implementation lazy-pattern convention. Public options and markup contract are unchanged. The implementation now loads only on pages with a .pat-recurrence element, in its own chunk.
petschki
force-pushed
the
mockup-lazy-recurrence
branch
from
July 17, 2026 10:06
3fe5eb5 to
901d89c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pat-recurrence was the single largest pattern in the eager patterns chunk (~52KB src, incl. three statically-imported XML templates and the Modal dependency), loaded on every page though the widget only appears on Event add/edit forms.
Split it into a thin registration module (trigger, parser, and an init() that dynamically imports the implementation on first match) plus recurrence--implementation.js holding the widget, the XML templates and the Modal import. Follows the existing tinymce--implementation lazy-pattern convention.
addresses #1618