Skip to content

chore(catalog): record the Boot rebuild backfill - #247

Merged
amondnet merged 1 commit into
mainfrom
catalog/boot-rebuild-backfill
Sep 16, 2026
Merged

amondnet merged 1 commit into
mainfrom
catalog/boot-rebuild-backfill

Conversation

@amondnet

@amondnet amondnet commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Closes #141.

Repoints all 47 published Boot entries at their +rebuild.1 tag and updates the committed tree under markdown/boot/. One pull request rather than 47: every catalog branch is cut from the default branch, so the automatic ones conflict with each other — same shape as #72, #136 and #198.

What the rebuilt archives fix

Defect Cause Affected versions
{version-spring-boot}, {version-graal} Listings read from getSource() — the one text where AsciiDoc's substitutions have not run — while Boot writes every "add the dependency" snippet as [source,xml,subs="verbatim,attributes"] (#140) all 47
{version-testcontainers-*} addTestcontainersDependencyVersion was never ported into the synthesized era (#199) 3.3.6–3.3.12, 3.4.0–3.4.6, 3.5.0 — 18 each
{version-<spring-data-module>-docs/-javadoc} 3.3.4 and 3.3.5 emit these publicly; 3.3.6 moved the values behind the internal antoraversion-/dotxversion- names (#199) 3.3.4, 3.3.5

Done-when

$ grep -ro '{version-[a-z0-9-]*}' markdown/boot | wc -l
94
$ grep -rho '{version-[a-z0-9-]*}' markdown/boot | sort | uniq -c
  94 {version-spring-boot}

Exactly two per version, and both are upstream's own, not ours: the last of four otherwise identical [source,shell] blocks in tutorial/first-application and in native-image/developing-your-first-application omits subs="verbatim,attributes", so docs.spring.io renders it literally too. Verified against the published HTML:

docs.spring.io/spring-boot/3.3.0/tutorial/first-application/index.html
  → ["3.3.13", "3.3.13", "3.3.13", "{version-spring-boot}"]

The issue's original "empty" criterion is therefore unreachable; #141 carries the corrected one.

Provenance

Recorded from the published archives rather than from a local rebuild — each downloaded, checked against its .sha256 asset, extracted, promoted, and dated from the release's own publishedAt. All 47 releases published green; four (3.3.6, 3.3.7, 3.5.6, 3.5.7) stalled in their first run's Build step and were re-dispatched through the workflow_dispatch recovery path, succeeding in 10–12s like the rest.

Supersedes the 47 automatic catalog pull requests, which are closed with their branches.


Summary by cubic

Repoints all 47 published Boot entries at their +rebuild.1 tags and updates the committed markdown to replace unresolved version placeholders with actual values from the rebuilt archives, closing #141.

Details

  • Replaced {version-spring-boot} and {version-graal} in dependency snippets that were not substituted because of subs="verbatim,attributes".
  • Fixed missing Testcontainers version placeholders in 3.3.6–3.3.12, 3.4.0–3.4.6, and 3.5.0.
  • Fixed Spring Data module version placeholders in 3.3.4 and 3.3.5.
  • Recorded from published archives verified against .sha256 assets.
  • Supersedes the 47 automatic catalog PRs.

Written for commit 231644b. Summary will update on new commits.

Repoints all 47 published Boot entries at their `+rebuild.1` tag and updates the
committed tree, closing #141.

Three conversion fixes land in these archives:

- `{version-spring-boot}` / `{version-graal}` in dependency snippets (#140).
  Listings were read from `getSource()`, the one text where AsciiDoc's own
  substitutions have not run, and Boot writes every "add the dependency" snippet
  as `[source,xml,subs="verbatim,attributes"]`.
- `version-testcontainers-*`, never ported from `addTestcontainersDependencyVersion`
  (#199). Affected 3.3.6-3.3.12, 3.4.0-3.4.6 and 3.5.0, 18 occurrences each.
- `version-<spring-data-module>-docs` / `-javadoc`, emitted publicly by 3.3.4 and
  3.3.5 only (#199).

`grep -ro '{version-' markdown/boot` now returns 94 — exactly two per version,
both upstream's own: a `[source,shell]` block in `tutorial/first-application` and
in `native-image/developing-your-first-application` omits `subs="attributes"`,
which docs.spring.io renders literally too.

Recorded from the published archives rather than a local rebuild: each was
downloaded, checked against its `.sha256` asset, extracted, and dated from the
release's own `publishedAt` — the same provenance chain as #72, #136 and #198.
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@sonarqubecloud

Copy link
Copy Markdown

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the catalog and committed Boot trees cover the same 47 versions and the substitutions satisfy the stated residual-placeholder invariant.

Summary

This PR records the Spring Boot rebuild backfill by repointing every published Boot catalog entry to its corresponding +rebuild.1 release and promoting the corrected generated Markdown.

  • Updates all 47 Boot catalog tags and their rebuild publication timestamps.
  • Replaces unresolved generated version attributes with release-appropriate literals across the Boot documentation trees.
  • Resolves Testcontainers and Spring Data documentation-link attributes in the affected releases.
  • Preserves exactly the documented two upstream {version-spring-boot} literals per Boot version.

Reviews (1) · Last reviewed commit: "chore(catalog): record the Boot rebuild ..."

@amondnet
amondnet merged commit 6566977 into main Sep 16, 2026
9 checks passed
@amondnet
amondnet deleted the catalog/boot-rebuild-backfill branch September 16, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rebuild the 47 published Boot releases: their dependency snippets ship a literal {version-spring-boot}

1 participant