Repository navigation
feat(gate): explicit approve and a machine-readable decision - #122
Merged
Merged
Conversation
- `plannotator-tui <file|folder> --gate` adds Approve (`A`, and an
`Approve (A)` header button) beside Send and quit. The review ends with
one decision: approved (unsent notes ride along as approval notes),
annotated (a successful send) or dismissed (quit). Without `--gate`
nothing changes.
- output matches `plannotator annotate --gate`: plaintext `The user
approved.` or the approved-with-notes message; `--json` prints
`{"decision","feedback"}` plus `annotationCount` and `target`;
`--require-approval` exits 0 only on approval; `--result-file`
publishes the strict record atomically and never overwrites. Strict
flags need `--gate --json`, and the gate's own failures exit 2.
- `herdr open --gate [--result-file PATH]` delivers the approval message
or the numbered feedback to the agent pane and publishes the result.
- the feedback archive records approved, approved-with-notes and
dismissed in the browser's shape.
refs #121
This was referenced Oct 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in gate mode, matching
plannotator annotate --gatein the browser. Without--gate, nothing changes.plannotator-tui <file|folder> --gateadds Approve (A, plus a header button). Approving with notes unsent is allowed. Send still means "annotated", and quitting means "dismissed".--jsonprints{"decision":"approved|annotated|dismissed","feedback":"..."}, the same records as the browser.--require-approvalexits with 0 when approved, 1 when annotated or dismissed, and 2 when the gate itself fails.--result-file <path>writes the decision atomically and never overwrites an existing file.herdr open --gate [--deliver-to PANE] [--result-file PATH]sends the agent "The user approved.", the browser's approved-with-notes message, or the numbered feedback as today, and writes the result file.approved,approved-with-notes,feedback,dismissed).Limits:
--result-fileand can't capture stdout.herdr open --gatereturns as soon as the pane opens, so its exit code doesn't carry the decision.Closes #121