Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Fixable/NewClassNamesVisitor.php
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,22 @@ private function parsePhpDoc(Doc $doc): PhpDocNode

/**
* Function and constant names are not class names,
* a use statement imports a name as it is written,
* and `self` is not valid PHP everywhere a class name is.
*/
private function markNames(Node $node): void
{
if ($node instanceof Stmt\Use_) {
foreach ($node->uses as $useItem) {
if (!$useItem->name instanceof FullyQualified || $useItem->name->getAttribute('origNode') !== null) {
continue;
}

$useItem->name = new Name($useItem->name->toString());
}
return;
}

if ($node instanceof Node\Expr\FuncCall || $node instanceof Node\Expr\ConstFetch) {
$node->name->setAttribute(self::SKIP_ATTRIBUTE, true);
return;
Expand Down
41 changes: 41 additions & 0 deletions tests/PHPStan/Fixable/RenameUseRule.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<?php declare(strict_types = 1);

namespace PHPStan\Fixable;

use PhpParser\Node;
use PhpParser\Node\Name\FullyQualified;
use PHPStan\Analyser\Scope;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;

/**
* Replaces the imported RenameUseOther\Foo with a fully qualified RenameUseOther\Bar.
*
* @implements Rule<Node\Stmt\Use_>
*/
final class RenameUseRule implements Rule
{

public function getNodeType(): string
{
return Node\Stmt\Use_::class;
}

public function processNode(Node $node, Scope $scope): array
{
if ($node->uses[0]->name->toString() !== 'RenameUseOther\Foo') {
return [];
}

return [
RuleErrorBuilder::message('Import RenameUseOther\Bar.')
->identifier('tests.renameUse')
->fixNode($node, static function (Node\Stmt\Use_ $use): Node\Stmt\Use_ {
$use->uses[0]->name = new FullyQualified('RenameUseOther\Bar');
return $use;
})
->build(),
];
}

}
24 changes: 24 additions & 0 deletions tests/PHPStan/Fixable/RenameUseRuleTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php declare(strict_types = 1);

namespace PHPStan\Fixable;

use PHPStan\Rules\Rule;
use PHPStan\Testing\RuleTestCase;

/**
* @extends RuleTestCase<RenameUseRule>
*/
class RenameUseRuleTest extends RuleTestCase
{

protected function getRule(): Rule
{
return new RenameUseRule();
}

public function testFix(): void
{
$this->fix(__DIR__ . '/data/rename-use.php', __DIR__ . '/data/rename-use.php.fixed');
}

}
10 changes: 10 additions & 0 deletions tests/PHPStan/Fixable/data/rename-use.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php declare(strict_types = 1);

namespace RenameUse;

use RenameUseOther\Foo;
use RenameUseOther\Foo as Lorem;

function doFoo(Foo $foo, Lorem $lorem): void
{
}
10 changes: 10 additions & 0 deletions tests/PHPStan/Fixable/data/rename-use.php.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php declare(strict_types = 1);

namespace RenameUse;

use RenameUseOther\Bar;
use RenameUseOther\Bar as Lorem;

function doFoo(Foo $foo, Lorem $lorem): void
{
}
Loading