Repository navigation
Keep the full name of a class a fix writes into a use statement - #6929
Open
SanderMuller wants to merge 1 commit into
Open
SanderMuller wants to merge 1 commit into
SanderMuller wants to merge 1 commit into
Conversation
NewClassNamesVisitor wrote a fully qualified name that a fix put into a use statement relative to the alias of that same statement. A fix that replaced `use Foo\Old;` with `Foo\New` gave `use New;`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix that puts a
FullyQualifiedname into a use statement gets only the short name. When a rule replaces the name inuse RenameUseOther\Foo;withnew FullyQualified('RenameUseOther\Bar'),--fixwritesuse Bar;. With an alias it writesuse Lorem as Lorem;.NewClassNamesVisitortreats the name like any other class name that a fix added. It writes the name relative to the alias that the same use statement creates. Now a newFullyQualifiedname in a use statement becomes a plainName, so the statement keeps the full name. If the visitor only skipped the name, the statement would get a leading backslash.I hit this in a rule that renames a class and every reference to it.
🤖 Generated with Claude Code