[bonelifer]

Builds the extension described in docs/design.md, with the change asked for in the design review (#2).

What it adds

• ACP → Extensions → See Notes: the list of reasons (description, color, order, on/off switch) and the settings (label, require a description, allow deleting a reason with all its entries).
• Seven starter reasons, added on first enable in the board's default language: Moderation queue, Spam watch, Warez, Conduct, Possible returning member, Staff in contact and General. A board that already has reasons gets none.
• MCP → Moderator notes and ACP → Manage users → Moderator notes: give a member a reason, choose the current one or none, add, edit and delete notes, and delete an entry. The member's latest phpBB user notes show read-only below.
• Notes use BBCode, smilies and links with the board's private message settings, so a PM sent to the member can be pasted into a quote (Design review: See Notes #2).
• Staff see "SEE NOTES: Moderation queue (2)" on profiles, next to posts, on the MCP post, report and approval queue pages, and in the MCP topic view. A member with no current reason shows "SEE NOTES: NONE", which links to the form that gives one.
• Separate moderator and administrator permissions, moderator logging, and clean-up when a member is deleted or renamed.
• Screenshots in the README and in docs/images/screenshots.

Testing

Claude ran:

• PHPUnit (22 tests) against phpBB 3.3.x and master.
• EPV against 3.3.x and master, the code sniffer with both rulesets, and php -l on PHP 7.4 and 8.4.
• A new feature check (29 checks, added to phpbbmodders/phpbb-release-tools) on phpBB 3.3 and 4.0, each with SQLite, MySQL, MariaDB, PostgreSQL and MSSQL, including disable, purge and enable.
• axe-core and keyboard checks on the See Notes pages at desktop and phone widths.
• The validation prompt. Its findings are fixed in this branch, along with a phpBB 4.0 bug the feature check found: 4.0 dropped an argument from generate_text_for_storage(), which blocked quotes in notes.

Closes #2

---

Investigated and written by Claude on behalf of William Jacoby (bonelifer).

[bonelifer]

Pushed a56b17e: the MSSQL jobs failed on one unit test, because phpBB's MSSQL driver returns '' instead of NULL for a missing LEFT JOIN row. The page already treats both as a deleted member; the test now accepts either.

---

Investigated and written by Claude on behalf of William Jacoby (bonelifer).

[bonelifer]

Pushed 66894fe, bd6d580 and 826aee7: enabling the extension now adds seven starter reasons (Moderation queue, Spam watch, Warez, Conduct, Possible returning member, Staff in contact, General) with descriptions and colors, in the board's default language. A separate migration adds them and skips any board that already has reasons, so nothing is duplicated. The Spam watch color is darker so it passes WCAG AA contrast, and the screenshots were retaken.

Claude tested a fresh install and a board that already had reasons on phpBB 3.3 and 4.0, and ran the feature check on both branches with SQLite, MySQL, MariaDB, PostgreSQL and MSSQL.

---

Investigated and written by Claude on behalf of William Jacoby (bonelifer).