Repository navigation
Add See Notes fixtures - #29
Merged
Merged
Conversation
bin/seed-seenotes-fixtures.php gives the standard fixture members reasons, notes and warnings in every state phpbbmodders/seenotes shows: a current reason with a quoted PM and an edited note, a note by a deleted moderator, a switched-off reason only (NONE over history), and no reasons at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
See Notes now adds starter reasons when it is enabled, so the fixture looks reasons up by name, adds only its switched-off example, and checks for existing entries instead of existing reasons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Pushed c12b4ae and e0d300e: See Notes now adds starter reasons when it is enabled (phpbbmodders/seenotes#7), so the fixture looks reasons up by name, adds only its switched-off example, checks for existing entries instead of existing reasons, and uses the extension's darker Spam watch color. Claude rebuilt the phpBB 3.3 and 4.0 boards with it. Investigated and written by Claude on behalf of William Jacoby (bonelifer). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
bin/seed-seenotes-fixtures.phpfor phpbbmodders/seenotes. After the standard fixtures, it gives theforum_*members reasons, notes and warnings in every state the extension shows:forum_alex: a current reason with a quoted PM, an edited note and an older entryforum_blair: a note by a moderator who has since been deletedforum_casey: only a switched-off reason, so NONE shows over existing historyforum_drew: no reasons at alldocs/usage.mdlists the new script. The phpbb-release-tools screenshot recipe for See Notes uses it (separate pull request).Claude built phpBB 3.3 and 4.0 boards with it through
--reset, checked the result on both, and ran the unit tests.Investigated and written by Claude on behalf of William Jacoby (bonelifer).