Repository navigation
Add screenshots.py --seed-board and Restore Jumpbox screenshots - #74
Merged
Merged
Conversation
screenshots.py can now take an extension's screenshots on an installed seed-forum board (--seed-board, through _board.SeedBoard as feature_checks.py and page_a11y.py already do), so phpBB 4.0-only extensions and boards built from an open phpbb/phpbb pull request can be shot. The board is not reset; only its name and description change for the shots and are put back. shots_restorejumpbox saves the open "Jump to" list on a forum page, a topic page and a phone-width forum page, and the extension's ACP Load settings fieldset. It needs a board built from phpbb/phpbb#6927, for example the one db-matrix.sh -b master -d sqlite -P 6927 -k keeps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screenshots.pycould only shoot on a board fromsetup-board.sh, and that script only builds phpBB 3.3 releases. So phpBB 4.0-only extensions, such as Restore Jumpbox, had no screenshot recipe.--seed-board BOARD_ROOT(-S): takes an extension's screenshots on an installed seed-forum board that already has the extension enabled. It uses_board.SeedBoard, the same class behindfeature_checks.py --seed-boardandpage_a11y.py --seed-board. seed-forum already buildsmasterboards and boards from open phpbb/phpbb pull requests (board.phpbb_pull_request), anddb-matrix.sh -P N -kbuilds one and keeps it. That made this option a smaller change than teachingsetup-board.sha second way to clone and install master and pull requests. The board is not reset: only its name and description change for the screenshots, and both are put back afterwards.--seedand--withare refused with--seed-board, since seed-forum seeds the board and enables what it needs. The steps that serve the board and run the recipe moved intotake_shots(), so both kinds of board go through the same code.shots_restorejumpbox: the "Jump to" list opened at the bottom of General Discussion, a topic page and a phone-width forum page, all as a guest. The list shows the nested Member Projects forum and leaves out the Staff Room, which guests can't see. The fourth shot is ACP → General → Load settings, cropped to the extension's "Restore Jumpbox" fieldset. The recipe stops with an error unless the board is a seed-forum board built from [ticket/17609] Remove jumpbox phpbb/phpbb#6927, because the extension does nothing while core still has its own jumpbox.--seed-board.phpbb-test-board/db-matrix.sh -b master -d sqlite -P 6927 -k path/to/restorejumpbox phpbb-test-board/screenshots.py path/to/restorejumpbox -o path/to/restorejumpbox/docs/images/screenshots \ --seed-board ~/.cache/phpbb-release-tools/db-matrix/boards/master-pr6927-sqlite --port 8130Testing
Claude ran these locally:
db-matrix.sh -b master -d sqlite -P 6927 -kwith Restore Jumpbox: board built, 17/17 feature checks passed.screenshots.py --seed-boardon that board (phpBB 4.0.0-a2-dev): 4 saved, 0 failed, no PHP errors. The board's name and description were back to their old values afterwards.setup-board.shboard with--seedand phpbbmodders/elonw saved 2 shots with 0 failures.tests/test-phpbb-test-board.shpasses, and the CI's ShellCheck command is clean.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code