Repository navigation
Replace the screenshots with ones taken by screenshots.py - #5
Merged
Merged
Conversation
The four screenshots are now taken with phpbb-release-tools' screenshots.py (shots_restorejumpbox) on a seed-forum board built from phpbb/phpbb#6927 with the standard fixtures, instead of by hand. The ACP shot is cropped to the extension's fieldset, so its preview size changes. The gallery says how the screenshots are made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The screenshots were taken by hand. They are now made with phpbb-release-tools'
screenshots.py, using the recipe added in phpbbmodders/phpbb-release-tools#74. The board was built from phpbb/phpbb#6927 with seed-forum's standard fixtures. Anyone can take them again with the two commands in the phpbb-test-board README.docs/images/screenshots/README.md): a line saying how the screenshots are made. The README still shows three previews at 440 px and links to the gallery.No code changes.
Testing
Claude took the screenshots with
screenshots.py --seed-boardon a phpBB 4.0.0-a2-dev board built from phpbb/phpbb#6927: 4 saved, 0 failed, no PHP errors. On the same board,db-matrix.shpassed 17/17 of the extension's feature checks.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code