Repository navigation
Add a Restore Jumpbox feature check and pull-request boards in db-matrix - #73
Merged
Merged
Conversation
check_restorejumpbox covers the selector on forum and topic pages, its permission filtering, and the ACP visibility setting on a board built from phpbb/phpbb#6927, and that the extension stays out of the way where core still has its jumpbox. db-matrix.sh -P N builds the master boards from that pull request through seed-forum's board.phpbb_pull_request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a feature check for phpbbmodders/restorejumpbox, and a
db-matrix.shoption to build the phpBB 4.0 boards from an open phpbb/phpbb pull request, which that check needs.Needs phpbbmodders/seed-forum#36, which adds the
board.phpbb_pull_requestsetting the new option writes. Merge that one first.Changes
feature_checks.py:check_restorejumpbox. On a board built from [ticket/17609] Remove jumpbox phpbb/phpbb#6927 (core jumpbox removed), it checks:On a phpBB that still has its own jumpbox, it checks that only core's selector is shown.
db-matrix.sh:-P/--phpbb-pull-request Nwritesphpbb_pull_request: Ninto themasterboard configs and gives those boards their ownmaster-prN-<database>folders.phpbb-test-board/README.md: documents-P.Testing
Claude ran
db-matrix.sh -b master -P 6927against restorejumpbox on SQLite, MySQL, MariaDB, PostgreSQL and MSSQL: 17/17 checks passed on each, including the disable/purge/enable round trip. A plainmasterSQLite board passed the "only core's selector" case.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code