Skip to content

Maintenance pass: README, TODO, language service and migration dependency - #4

Merged
bonelifer merged 2 commits into
mainfrom
varma/restorejumpbox
Nov 13, 2026
Merged

bonelifer merged 2 commits into
mainfrom
varma/restorejumpbox

Conversation

@bonelifer

Copy link
Copy Markdown
Collaborator

A maintenance pass: README brought up to the organization's layout, the TODO rewritten now that the first milestone is built, and two small code fixes from validation.

Changes

  • README: Tests and Lint badges, a first line matching the composer and GitHub descriptions, and Features, Requirements and Installation sections. Also the standard TODO and Contributing sections (now with the community forum), and Claude added to Acknowledgments.
  • docs/TODO.md: replaces the first-milestone scope with what's still open: rechecking the final [ticket/17609] Remove jumpbox phpbb/phpbb#6927 diff and the new 4.0 style, the other pages the removal touched, and an index placement idea.
  • Language service: the ACP listener loads its language file through \phpbb\language\language::add_lang() instead of user::add_lang_ext(), which phpBB marks for removal in 4.0.
  • Migration: add_visibility_setting now depends on \phpbb\db\migration\data\v400\v400a1, matching the extension's phpBB 4.0 minimum.

Outside the code: the GitHub description now matches composer.json, Projects is off, and the jumpbox and prosilver topics and the Infrastructure and Development Claimed labels were added.

Testing

  • EPV on phpBB 3.3.x and master: no findings. Code sniffer and composer validate: clean. php -l on PHP 8.2 and 8.5: clean.
  • Template accessibility scan (template_a11y.py): no problems. On a live board, Claude checked the selector at desktop and phone widths. Enter opens it and sets aria-expanded, Tab moves into its links, and Escape closes it and returns focus to the button. axe found no violations in the open selector.
  • Claude ran the new restorejumpbox feature check (Add a Restore Jumpbox feature check and pull-request boards in db-matrix phpbb-release-tools#73) on boards built from [ticket/17609] Remove jumpbox phpbb/phpbb#6927 on SQLite, MySQL, MariaDB, PostgreSQL and MSSQL. All 17 checks passed on each, including the ACP setting saved through the real form and a disable/purge/enable round trip. On plain master, which still has core's jumpbox, the extension stays out of the way.

Investigated and written by Claude on behalf of William Jacoby (bonelifer).

🤖 Generated with Claude Code

bonelifer and others added 2 commits November 13, 2026 11:10
user::add_lang_ext() is marked for removal in phpBB 4.0; load the ACP
language file through \phpbb\language\language::add_lang() instead.
The visibility setting's migration now depends on v400a1, matching the
extension's phpBB 4.0 minimum.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the Tests and Lint badges and the Features, Requirements and
Installation sections, match the first line to the composer and GitHub
descriptions, and use the organization's TODO and Contributing wording.
Rewrite docs/TODO.md as the list of what is still open now that the
first milestone is built.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer
bonelifer merged commit 1ef96c1 into main Nov 13, 2026
9 checks passed
@bonelifer
bonelifer deleted the varma/restorejumpbox branch November 13, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant