Repository navigation
Maintenance pass: README, TODO, language service and migration dependency - #4
Merged
Merged
Conversation
user::add_lang_ext() is marked for removal in phpBB 4.0; load the ACP language file through \phpbb\language\language::add_lang() instead. The visibility setting's migration now depends on v400a1, matching the extension's phpBB 4.0 minimum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the Tests and Lint badges and the Features, Requirements and Installation sections, match the first line to the composer and GitHub descriptions, and use the organization's TODO and Contributing wording. Rewrite docs/TODO.md as the list of what is still open now that the first milestone is built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A maintenance pass: README brought up to the organization's layout, the TODO rewritten now that the first milestone is built, and two small code fixes from validation.
Changes
\phpbb\language\language::add_lang()instead ofuser::add_lang_ext(), which phpBB marks for removal in 4.0.add_visibility_settingnow depends on\phpbb\db\migration\data\v400\v400a1, matching the extension's phpBB 4.0 minimum.Outside the code: the GitHub description now matches composer.json, Projects is off, and the
jumpboxandprosilvertopics and theInfrastructureandDevelopment Claimedlabels were added.Testing
composer validate: clean.php -lon PHP 8.2 and 8.5: clean.template_a11y.py): no problems. On a live board, Claude checked the selector at desktop and phone widths. Enter opens it and setsaria-expanded, Tab moves into its links, and Escape closes it and returns focus to the button. axe found no violations in the open selector.master, which still has core's jumpbox, the extension stays out of the way.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code