Repository navigation
Conversation
|
Another PR, stacked on top of the other one that I mentioned already: crmne#2 |
There was a problem hiding this comment.
FYI, some things I noticed while working on the follow-ups in crmne#1.
With the fixture tool fix from that PR the regular suite now loads on RubyLLM 2, but about 375 examples still fail there. Most are in chat_spec (gemini-2.0-flash is gone from the 2.0 registry, bare claude-sonnet-4 resolves to Vertex AI, and OpenAI now calls /v1/responses so the recorded cassettes don't match), about 57 are in tool_spec asserting on MCP::Content where 2.0 tools now return a String, and the rest are smaller groups in the elicitation, sample, resource, and agents specs. Happy to share the full breakdown.
Two different ways I can see to get the suite green on both versions:
- pin providers explicitly, skip the registry lookup, and pin OpenAI to chat completions on 2.0 so the existing cassettes replay on both (the approach in Support RubyLLM 2.0 #159)
- or, record cassettes that hold both versions' requests, since VCR here matches on method and URL only. I have a set recorded against 2.0's defaults on a 2.0-only branch if useful, though they'd need a 1.x pass added.
It seems worth doing something here because the sampling bug fixed in crmne#1 only shows up in the regular suite, which CI currently never runs on 2.0.
|
There is still at least one thing that needs handling in this PR: #159 (comment) |
|
Can I do anything to help getting this moving @crmne ? |
|
Hey everyone! Apologies on the slowest for this MR. I'm going to get this reviewed/merged today and get a new version out that will support RubyLLM 2.0 today! |
|
Actually looks like RubyLLM is shipping with MCP implementation now in 2.1. Great looking API (wish I thought of that!) and with the direction of the new MCP spec implementation has simplified a lot. So moving forward, I believe the plan is get our a compatibility change to support 2.0. Then after that deprecate the gem, and suggest new version of RubyLLM use the native gems support. I'll work on getting that all shipped in the next few days and slowly wind down the gem to be in a frozen state. |
|
Thanks for the update and for all the work on the gem! For what it's worth from a downstream user: we've just moved our app to RubyLLM 2.1's built-in |
|
That's great to hear, thanks @NielsKSchjoedt |
RubyLLM 2 removes
RubyLLM::Contentand reads tool schemas throughparameters_schema, so loading and using MCP tools fails even if the dependency constraint is relaxed. This supports RubyLLM >= 1.9 and < 3 while preserving the RubyLLM 1.x content API.Validation on Ruby 4.0.7:
This PR is limited to RubyLLM compatibility; it does not move MCP into RubyLLM core or change OAuth and transport policy.