Repository navigation
Run on ruby_llm 1.16 or 2.x; bump to 0.7.0 - #87
Merged
Merged
Conversation
special_sauce is moving to ruby_llm 2.0, and 0.6.1's ~> 1.16 pins keep it from resolving thingie in the same bundle. Widen the gemspec to ruby_llm >= 1.16, < 3 (mcp >= 1.0, < 2; skills >= 0.3.0, < 1) and route the four APIs that changed through Thingie::LlmCompat: - param :x, desc: -> parameter :x, description: - message.input_tokens (etc.) -> message.tokens.input - models.refresh! -> models.refresh - models.load_from_json! -> models.load_from_json A default bundle still resolves to 1.16 (released ruby_llm-mcp and ruby_llm-skills require 1.x). gemfiles/ruby_llm_2.gemfile pins the 2.x set, and CI runs the specs on both. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- message_double builds an instance_double(RubyLLM::Message) from 1.16-style token keys, as RubyLLM::Tokens on 2.x; model_info_class is Model::Info on 1.16 and Model on 2.x. - models.find takes one argument on 2.x (1.16 accepts it too). - YARD @PARAM tags for LlmCompat's registry helpers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Outdated Thingie summary1 Thingie finding(s) outside this diff
|
1.16 also has Message#tokens, shaped differently (cached, cache_creation), so checking #tokens first read a missing field on 1.16. Use the readers when the message has them; message_double detects 1.16 the same way. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Outdated Thingie summary2 Thingie finding(s) outside this diff
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pdw207
commented
Sep 29, 2026
| gem 'ruby_llm', '~> 2.0' | ||
| gem 'ruby_llm-skills', '0.5.0.pre1' | ||
| # patvice/ruby_llm-mcp#161: RubyLLM 2 support, not released yet. | ||
| gem 'ruby_llm-mcp', github: 'crmne/ruby_llm-mcp', ref: 'a8cc59c1647905b81b56bfda4b82b1db17e7e967' |
Contributor
Author
There was a problem hiding this comment.
Testing thingie with LLM 2.0
pdw207
commented
Sep 29, 2026
|
|
||
| module Thingie | ||
| VERSION = '0.6.1' | ||
| VERSION = '0.7.0' |
pdw207
marked this pull request as ready for review
September 29, 2026 19:39
1 Thingie finding(s) outside this diff
|
Contributor
Author
|
integration testing with https://github.com/bonusly/special_sauce/pull/27510 and https://github.com/bonusly/special_sauce/pull/27510 |
Contributor
Author
|
Integration test successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets thingie run in a bundle on either ruby_llm 1.16 or 2.x, so special_sauce can move to ruby_llm 2.0 (bonusly/special_sauce#27487) without thingie holding it back. 0.6.1 pins
ruby_llm ~> 1.16,ruby_llm-mcp ~> 1.0andruby_llm-skills ~> 0.3.0, so Bundler can't resolve it next to 2.0.ruby_llm >= 1.16, < 3,ruby_llm-mcp >= 1.0, < 2,ruby_llm-skills >= 0.3.0, < 1. A default bundle still resolves to 1.16, because the released mcp and skills gems require 1.x.Thingie::LlmCompatroutes the four APIs that differ:param :x, desc:becomesparameter :x, description:message.input_tokens(and the other token readers) becomesmessage.tokens.inputmodels.refresh!becomesmodels.refreshmodels.load_from_json!becomesmodels.load_from_jsonLoader/Skill/SkillToolAPI thingie uses is identical in 0.3.0 and 0.5.0.pre1, andRubyLLM.contextand response parsing already work on both.Specsjob is unchanged (1.16). A newSpecs (ruby_llm 2)job runs withgemfiles/ruby_llm_2.gemfile: ruby_llm 2.0, skills 0.5.0.pre1, and mcp from Support RubyLLM 2 while preserving RubyLLM 1 compatibility patvice/ruby_llm-mcp#161.I couldn't run
bundle exec rakelocally becauseruggeddoesn't build on this machine. CI runs the specs on both bundles and passes; RuboCop hasn't been run.Bumps the version to 0.7.0. After merge: tag
0.7.0, move special_sauce main to it (still on 1.16), and restore thingie in #27487.🤖 Generated with Claude Code