chore: replace the code owners with the people who can approve - #314
Merged
Merged
Conversation
The file named @waytwotall and @sphamjoli. @sphamjoli has read access and has left the organisation, so they cannot approve a pull request, which left one person able to satisfy a code-owner review on the whole repository. That is about to matter. The "main" ruleset is active but its target list is empty, so it currently matches no branches and master is unprotected. Once its targets are set, every pull request needs a code-owner approval, and with the old list that meant @waytwotall or nothing. Replaces them with @re-gius and @GHkrishna, both of whom can approve. Two owners rather than one, because a code owner cannot approve their own pull request, so a single owner cannot merge anything they wrote. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
CI Summary
Labelsother |
The team outlives its membership: people joining and leaving @paritytech/dotns is a team-settings change, and this file stops needing a pull request every time that happens, which is exactly how it went stale last time. Inert until the team is granted write on this repository: CODEOWNERS ignores teams without access, so that grant lands before this merges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 of 16 tasks
charlesHetterich
added a commit
to paritytech/dotns-sdk
that referenced
this pull request
Sep 23, 2026
## Description Replaces the single code owner with @paritytech/dotns, matching what dotns did in paritytech/dotns#314, and deletes the Request Code Owner Review workflow. The workflow hardcoded four individuals with a "keep in sync with CODEOWNERS" comment, and the two had already drifted. GitHub requests code owner reviews natively, so with CODEOWNERS pointing at the team, every PR reaches the whole team with no list to maintain. ## Type - [ ] Bug fix - [ ] Feature - [ ] Breaking change - [ ] Documentation - [x] Chore ## Package - [ ] `@parity/dotns-cli` - [ ] Root/monorepo - [ ] Documentation ## Related Issues ## Fixes Outdated repository configuration. ## Checklist ### Code - [x] Follows project style - [ ] `bun run lint` passes - [ ] `bun run format` passes - [ ] `bun run typecheck` passes ### Documentation - [ ] README updated if needed - [ ] Types updated if needed ### Breaking Changes - [x] No breaking changes - [ ] Breaking changes documented below **Breaking changes:** ## Testing None needed; GitHub evaluates CODEOWNERS at PR time. ## Notes --------- Co-authored-by: Charles Hetterich <hetterich.charles@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.github/CODEOWNERSnamed@waytwotalland@sphamjoli, which is outdated behavior.Now any member of the dotns team can approve.
Type
Scope
None: repository configuration only.
Related Issues
Precedes setting targets on the
mainruleset, which is what actually protects master.Fixes
A code-owner list that could not be satisfied once code-owner review is enforced.
Checklist
Code
forge buildpassesforge testpassesTesting
Security
selfdestructordelegatecallDocumentation
Breaking Changes
Breaking changes:
How to test
Nothing to run: one line of repository configuration, no contract or test changes.
Notes
Merge this before adding targets to the
mainruleset, while master is still unprotected and this can land without needing the approval it exists to make possible.🤖 Generated with Claude Code