Skip to content

chore: own the repository as a team - #315

Merged
charlesHetterich merged 3 commits into
mainfrom
chore/codeowners-team
Sep 23, 2026
Merged

charlesHetterich merged 3 commits into
mainfrom
chore/codeowners-team

Conversation

@re-gius

@re-gius re-gius commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Replaces the single code owner with @paritytech/dotns, matching what dotns did in paritytech/dotns#314, and deletes the Request Code Owner Review workflow. The workflow hardcoded four individuals with a "keep in sync with CODEOWNERS" comment, and the two had already drifted. GitHub requests code owner reviews natively, so with CODEOWNERS pointing at the team, every PR reaches the whole team with no list to maintain.

Type

  • Bug fix
  • Feature
  • Breaking change
  • Documentation
  • Chore

Package

  • @parity/dotns-cli
  • Root/monorepo
  • Documentation

Related Issues

Fixes

Outdated repository configuration.

Checklist

Code

  • Follows project style
  • bun run lint passes
  • bun run format passes
  • bun run typecheck passes

Documentation

  • README updated if needed
  • Types updated if needed

Breaking Changes

  • No breaking changes
  • Breaking changes documented below

Breaking changes:

Testing

None needed; GitHub evaluates CODEOWNERS at PR time.

Notes

@re-gius
re-gius requested a review from waytwotall as a code owner September 22, 2026 14:19
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

CI Summary

Check Result
Lint Passed
Format Passed
Typecheck Passed
Build Passed
PR Title Passed
Labels Passed

Labels

scope: benchmark

@charlesHetterich

Copy link
Copy Markdown
Contributor

Already approved but actually on closer look, the regexes in

  • .github/workflows/daily-deploy-sized-benchmarks.yml line 165
  • .github/workflows/benchmark-on-demand.yml line 296

Should be updated to handle the slash in @paritytech/dotns (Or just delete the block making the cc comments)

New regex /@[A-Za-z0-9][A-Za-z0-9-_/]*/g should work fine

@charlesHetterich
charlesHetterich merged commit 0e1158a into main Sep 23, 2026
12 checks passed
@charlesHetterich
charlesHetterich deleted the chore/codeowners-team branch September 23, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants