Repository navigation
docs: drop docker-zendc as a live caller - #106
Conversation
docker-zendc was decommissioned and archived (2026-10), so it is no longer a caller: removes it from the README/CLAUDE.md caller lists and examples, drops the unused zendc label from actionlint.yaml, and repoints the new-host and testing READMEs. Historical runbooks/plans/specs are left as written; the gitlab-container.zenterprise.org registry login is unchanged.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR removes docker-zendc as a live caller by updating caller and runner-label documentation, replacing its testing example, and deleting zendc from actionlint’s recognized self-hosted labels. Historical references, the Renovate description, and the registry login are intentionally retained to avoid changing historical context or deployment behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="CLAUDE.md" line_range="295" />
<code_context>
Follow `docs/superpowers/runbooks/adding-a-new-host.md` (the generic step-by-step procedure). Highlights:
-- Pick a unique runner label (e.g. `zendc`)
+- Pick a unique runner label (e.g. `piwine-office`)
- Add the label to **both** `compose-workflow/.github/actionlint.yaml` and the caller repo's `.github/actionlint.yaml`
- Run host prep (deploy user, path ownership pattern, `safe.directory`, umask 002 in admin's rcs)
</code_context>
<issue_to_address>
**Deployments target the wrong host**
When a new host is configured using the documented `piwine-office` label, the caller's `runner-label` matches the already registered office runner, so GitHub runs deployment jobs on that host instead of the intended machine, where `/opt/compose` may target a different checkout.
Replace the example with a unique runner label.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: CLAUDE.md:295
|
|
||
| Follow `docs/superpowers/runbooks/adding-a-new-host.md` (the generic step-by-step procedure). Highlights: | ||
| - Pick a unique runner label (e.g. `zendc`) | ||
| - Pick a unique runner label (e.g. `piwine-office`) |
There was a problem hiding this comment.
🟠 High · Deployments target the wrong host
When a new host is configured using the documented piwine-office label, the caller's runner-label matches the already registered office runner, so GitHub runs deployment jobs on that host instead of the intended machine, where /opt/compose may target a different checkout.
Replace the example with a unique runner label.
Prompt for AI agents
In `CLAUDE.md` at line 295:
**Deployments target the wrong host**
When a new host is configured using the documented `piwine-office` label, the caller's `runner-label` matches the already registered office runner, so GitHub runs deployment jobs on that host instead of the intended machine, where `/opt/compose` may target a different checkout.
Replace the example with a unique runner label.
docker-zendcwas decommissioned and archived (2026-10), so it is no longer a caller.zendc..github/actionlint.yaml: drops thezendclabel. Nothing in this repo uses it literally;runner-labelis an input.adding-a-new-host.md: still points at the archived repo, which is still readable, as the amd64 example.scripts/testing/README.md: the example path now usesdocker-piwine-office.Unchanged on purpose:
docker-zendcmention inside the longrenovate.jsoncustomManager descriptiongitlab-container.zenterprise.orgregistry login in lint and deploy. Removing it changes behaviour, so it needs its own decision.yamllint
--strictis clean. actionlint reports only the known, CI-ignoredjob.workflow_shaitems.Summary by Sourcery
Remove docker-zendc as an active workflow caller and update current runner documentation accordingly.
Enhancements:
Documentation: