Skip to content

docs: drop docker-zendc as a live caller - #106

Merged
owine merged 1 commit into
mainfrom
docs/drop-zendc
Oct 10, 2026
Merged

owine merged 1 commit into
mainfrom
docs/drop-zendc

Conversation

@owine

@owine owine commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

docker-zendc was decommissioned and archived (2026-10), so it is no longer a caller.

  • README / CLAUDE.md: caller lists say two repos and note the archive. Runner-label examples no longer suggest zendc.
  • .github/actionlint.yaml: drops the zendc label. Nothing in this repo uses it literally; runner-label is an input.
  • adding-a-new-host.md: still points at the archived repo, which is still readable, as the amd64 example.
  • scripts/testing/README.md: the example path now uses docker-piwine-office.

Unchanged on purpose:

  • historical runbooks, plans and specs
  • the docker-zendc mention inside the long renovate.json customManager description
  • the gitlab-container.zenterprise.org registry login in lint and deploy. Removing it changes behaviour, so it needs its own decision.

yamllint --strict is clean. actionlint reports only the known, CI-ignored job.workflow_sha items.

Summary by Sourcery

Remove docker-zendc as an active workflow caller and update current runner documentation accordingly.

Enhancements:

  • Update repository documentation and examples to reflect the current active caller repositories and runner labels after docker-zendc’s decommissioning.

Documentation:

  • Remove docker-zendc and zendc runner references from active caller lists, runner-label examples, and testing documentation while retaining historical references where appropriate.

docker-zendc was decommissioned and archived (2026-10), so it is no longer a
caller: removes it from the README/CLAUDE.md caller lists and examples, drops
the unused zendc label from actionlint.yaml, and repoints the new-host and
testing READMEs. Historical runbooks/plans/specs are left as written; the
gitlab-container.zenterprise.org registry login is unchanged.
@sourcery-ai

sourcery-ai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR removes docker-zendc as a live caller by updating caller and runner-label documentation, replacing its testing example, and deleting zendc from actionlint’s recognized self-hosted labels. Historical references, the Renovate description, and the registry login are intentionally retained to avoid changing historical context or deployment behavior.

File-Level Changes

Change Details Files
Update documentation to identify only the two active caller repositories and mark docker-zendc as archived.
  • Revise caller counts and archive status in repository overview documentation.
  • Remove zendc from runner-label examples and new-host guidance.
  • Replace the testing README’s archived-repository example with docker-piwine-office.
README.md
CLAUDE.md
scripts/testing/README.md
Remove the decommissioned runner label from actionlint’s self-hosted label configuration.
  • Delete zendc from the known self-hosted runner labels while retaining the active labels and explanatory hosted-runner configuration.
.github/actionlint.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="CLAUDE.md" line_range="295" />
<code_context>

 Follow `docs/superpowers/runbooks/adding-a-new-host.md` (the generic step-by-step procedure). Highlights:
-- Pick a unique runner label (e.g. `zendc`)
+- Pick a unique runner label (e.g. `piwine-office`)
 - Add the label to **both** `compose-workflow/.github/actionlint.yaml` and the caller repo's `.github/actionlint.yaml`
 - Run host prep (deploy user, path ownership pattern, `safe.directory`, umask 002 in admin's rcs)
</code_context>
<issue_to_address>
**Deployments target the wrong host**

When a new host is configured using the documented `piwine-office` label, the caller's `runner-label` matches the already registered office runner, so GitHub runs deployment jobs on that host instead of the intended machine, where `/opt/compose` may target a different checkout.

Replace the example with a unique runner label.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: CLAUDE.md:295


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread CLAUDE.md

Follow `docs/superpowers/runbooks/adding-a-new-host.md` (the generic step-by-step procedure). Highlights:
- Pick a unique runner label (e.g. `zendc`)
- Pick a unique runner label (e.g. `piwine-office`)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High · Deployments target the wrong host

When a new host is configured using the documented piwine-office label, the caller's runner-label matches the already registered office runner, so GitHub runs deployment jobs on that host instead of the intended machine, where /opt/compose may target a different checkout.

Replace the example with a unique runner label.

Prompt for AI agents
In `CLAUDE.md` at line 295:

**Deployments target the wrong host**

When a new host is configured using the documented `piwine-office` label, the caller's `runner-label` matches the already registered office runner, so GitHub runs deployment jobs on that host instead of the intended machine, where `/opt/compose` may target a different checkout.

Replace the example with a unique runner label.

@owine
owine merged commit 5e1d709 into main Oct 10, 2026
3 checks passed
@owine
owine deleted the docs/drop-zendc branch October 10, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant