Skip to content

docs(claude): don't suggest an existing runner label for a new host - #107

Merged
owine merged 1 commit into
mainfrom
docs/new-host-label-example
Oct 10, 2026
Merged

owine merged 1 commit into
mainfrom
docs/new-host-label-example

Conversation

@owine

@owine owine commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Sourcery review of #106: the new-host example label was piwine-office, which is already registered. Copying it would route a new host's deploys to the office Pi's runner. It's now a <node> placeholder with a note about why the label must be unique.

Summary by Sourcery

Update host onboarding guidance to require unique runner labels for new self-hosted hosts.

Bug Fixes:

  • Prevent the new-host setup example from encouraging reuse of an existing runner label, which could route deployments to the wrong host.

Documentation:

  • Clarify that each host must use a unique runner label and provide a placeholder for new host examples.

@sourcery-ai

sourcery-ai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the new-host documentation to use a non-copyable runner-label placeholder and explicitly warn that reusing an existing label can send deployments to the wrong host.

File-Level Changes

Change Details Files
Clarify that new self-hosted hosts must use a unique runner label to avoid routing deployments to an existing host.
  • Replace the concrete existing runner-label example with a <node> placeholder for new repositories.
  • Explain the docker-<node> naming relationship and the deployment-routing risk of reusing a registered label.
CLAUDE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="CLAUDE.md" line_range="295" />
<code_context>

 Follow `docs/superpowers/runbooks/adding-a-new-host.md` (the generic step-by-step procedure). Highlights:
-- Pick a unique runner label (e.g. `piwine-office`)
+- Pick a runner label no other host uses (e.g. `<node>` for a new `docker-<node>` repo; reusing an existing label such as `piwine` routes deploys to that host's runner)
 - Add the label to **both** `compose-workflow/.github/actionlint.yaml` and the caller repo's `.github/actionlint.yaml`
 - Run host prep (deploy user, path ownership pattern, `safe.directory`, umask 002 in admin's rcs)
</code_context>
<issue_to_address>
**Shared label does not route deploys**

When a new caller repo reuses a label registered only to another repo, the deploy job's label match is limited to runners registered for its own repository, so it does not reach the existing host; without a runner registered to the new repo, the job stays queued.

Replace the warning with the repository-scoped behavior: a reused label cannot select another repo's runner, and the new repo needs its own registered runner.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: CLAUDE.md:295


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread CLAUDE.md

Follow `docs/superpowers/runbooks/adding-a-new-host.md` (the generic step-by-step procedure). Highlights:
- Pick a unique runner label (e.g. `piwine-office`)
- Pick a runner label no other host uses (e.g. `<node>` for a new `docker-<node>` repo; reusing an existing label such as `piwine` routes deploys to that host's runner)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Shared label does not route deploys

When a new caller repo reuses a label registered only to another repo, the deploy job's label match is limited to runners registered for its own repository, so it does not reach the existing host; without a runner registered to the new repo, the job stays queued.

Replace the warning with the repository-scoped behavior: a reused label cannot select another repo's runner, and the new repo needs its own registered runner.

Prompt for AI agents
In `CLAUDE.md` at line 295:

**Shared label does not route deploys**

When a new caller repo reuses a label registered only to another repo, the deploy job's label match is limited to runners registered for its own repository, so it does not reach the existing host; without a runner registered to the new repo, the job stays queued.

Replace the warning with the repository-scoped behavior: a reused label cannot select another repo's runner, and the new repo needs its own registered runner.

@owine
owine merged commit ae700cc into main Oct 10, 2026
3 checks passed
@owine
owine deleted the docs/new-host-label-example branch October 10, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant