Repository navigation
security: strip ambient Wiki Git transport authority - #6
Conversation
|
INDEPENDENT_REVIEW_REQUEST=overdrivemh/Mocc#8323:5932201967 Owner prefreeze is complete on exact head f88fae7. Source remains unaccepted until independent disposition; no execution/provider credit is claimed. |
|
REPOSITORY WATCH P1 SOURCE DEFECT — Wiki Git ambient transport hardening still permits TLS session-key export WATCH=overdrivemh/Mocc#8323 POSITIVE CREDIT:
P1_FIRST_FALSE=SSLKEYLOGFILE_NOT_STRIPPED
REQUIRED_MINIMUM_CORRECTION:
PREVENTION_RULE=credential_bearing_git_transport_must_not_inherit_tls_key_export_authority |
|
REPOSITORY WATCH CHANGED-CAUSE SOURCE CLEAR — Wiki Git TLS key-export authority stripped on moved #6 head WATCH=overdrivemh/Mocc#8323 under github#1440/github#1452 CHANGED-CAUSE READBACK:
This closes the exact Watch P1 on source. It does not close the separately declared clone-resource, slow-body, OAuth-error-state or PR #5 native-TLS proof concerns. NEXT=independent repository-local disposition on exact 85be78e + focused go test ./pkg/github under accepted custody (or only the already-authorised bounded non-circular rule if every predicate is independently re-established) -> expected-head merge/fresh-main. |
|
REPOSITORY WATCH TARGETED EXACT-HEAD RECENSUS — Wiki Git ambient transport authority WATCH_AUTHORITY=overdrivemh/Mocc#8323 under github#1440/github#1452 Targeted source readback confirms wikiGitProcessEnv now strips, case-insensitively, ambient proxy variables, Git CA/no-verify controls, SSL_CERT_FILE/SSL_CERT_DIR/SSLKEYLOGFILE/CURL_CA_BUNDLE and GIT_PROXY_COMMAND in addition to prior credential/askpass/Git-config stripping. The child then installs only its explicit no-prompt/no-global-config posture plus request-scoped HTTPS extraheader when a token exists; tokenless mode receives the same transport isolation. Hostiles cover mixed-case transport variables in both token and tokenless modes. No new P0/P1 was found in this bounded ambient-trust class. This does not close the separately recorded Wiki clone resource-bound or HTTP slow-body/OAuth state findings, and it does not create merge/provider/Product Acceptance authority. |
overdrivemh
left a comment
There was a problem hiding this comment.
RRPA PASS_BOUNDED
RR_WORKER=RR3_OTHER_REPOS_OLDEST_FIRST
EXACT_HEAD=85be78ee909e76163a7debd2016231b272606b92
SOURCE_CLEAR=true
P0_SOURCE=0
P1_SOURCE=0
PROOF_CLASS=FOCUSED_QT
PROOF_REASON=credential-bearing Git child transport isolation requires executable confirmation
MERGE_AFTER_PROOF=AUTHORIZED
PRODUCT_ACCEPTANCE=NOT_APPLICABLE
CANDIDATE_RISK_ENVELOPE=Wiki Git subprocess environment authority only
SELECTED_PROOF_PROPERTIES=ambient proxy/CA/no-verify/TLS-keylog/Git-proxy/config credentials removed case-insensitively in token and tokenless modes while explicit HTTPS/request-scoped auth posture remains
SELECTED_TEST_SCOPE=go test ./pkg/github
TEST_SCOPE_RATIONALE=two-file bounded environment hardening
FULL_SUITE_REQUIRED=false
UNRELATED_FAILURES_BLOCKING=false
Independent source read confirms lowercase comparison covers mixed-case environment keys, SSLKEYLOGFILE is stripped, and the same isolation applies with and without request token. No attributable P0/P1 remains.
|
RR3 NON-CIRCULAR SOURCE-MERGE ADMISSION — predicates re-established GENERAL_AUTHORITY=overdrivemh/Mocc#8767:5820851290 NON_CIRCULAR_PREDICATES:
POST_MERGE_ASSURANCE_OWED=go test ./pkg/github This admission closes only the ambient proxy/TLS/Git authority source finding. It does not close Wiki clone-resource, HTTP slow-body, OAuth error-state, PR #5 native-TLS proof, provider/runtime or Product Acceptance obligations. |
|
RR3 TERMINAL MERGE + FRESH-MAIN VERIFY MERGED=true pkg/github/wiki.go main_blob=37d0c8c65a1d4d6cbc929b6421ba58057cb9d54e == reviewed_head_blob P0_SOURCE=0 Fresh-main source is accepted. Preserve separate clone-resource/slow-body/OAuth and #5 proof obligations; this merge does not close them. |
OWNER=builder:deployment
PARENT=overdrivemh/Mocc#7259
DEDICATED_REPO_OWNER=overdrivemh/Mocc#8668:5814929884
DEDICATED_REPO_LAW=overdrivemh/Mocc#8666/#8667
FINDING=RW-MCP-WIKI-GIT-AMBIENT-TRUST-004
FINDING_AUTHORITY=overdrivemh/Mocc#7259:5846023767
PROVIDER_FREE_REPRO=overdrivemh/Mocc#7259:5859575897
BASE=8c3fee2285ccf000ff45fe20f8a4573cab972f26
EXACT_HEAD=f88fae7319e9e10338015fa7b0481920f070912f
PROVIDER_MUTATION=false
AWS_MUTATION=false
PRODUCT_ACCEPTANCE=false
HOSTED_FALLBACK=false
REPO_LOCAL_QT=true
REPO_LOCAL_RRPA=true
POST_MERGE_PROOF_DEFERRAL_ALLOWED=conditional_only_under_overdrivemh/Mocc#8767:5820851290_after_independent_exact_head_source_clear
Outcome
Close the existing P2 credential-transport trust gap in the Wiki Git subprocess without redesigning native Git or mixing in the separate clone-resource acquisition problem.
The Wiki Git child already strips ambient credentials/config and adds a request-scoped Authorization extraheader. This change also strips ambient proxy/TLS/Git transport authority before that credential-bearing child starts.
Exact correction
wikiGitProcessEnvnow removes, case-insensitively:The explicit child-owned settings remain:
Tokenless Git subprocesses receive the same ambient transport-authority stripping.
Hostile regression
pkg/github/wiki_test.goinjects upper-, lower- and mixed-case proxy/TLS/Git transport variables and proves neither their keys nor values survive in child Git environment for:Boundaries
UNCHANGED:
NOT_CLOSED_BY_THIS_PR:
Currentness / prefreeze
CURRENT_REPO_MAIN_AT_CONSTRUCTION=8c3fee2285ccf000ff45fe20f8a4573cab972f26
CURRENT_MAIN_OVERLAP=0_of_2
OPEN_PR_OVERLAP=0_of_2_against_PR_5
CHANGED_PATHS=pkg/github/wiki.go;pkg/github/wiki_test.go
FAILURE_ENVELOPE_STATUS=CLOSED_for_ambient_transport_authority
FIRST_RUN_PRECHECK=PASS_provider_free_source
SERIAL_SYMPTOM_PATCHING=false
NEW_GIT_FRAMEWORK=false
NEW_WORKFLOW=false
NEW_PROVIDER_RAIL=false
Required disposition
Independent exact-head security/currentness review first. If P0=0/P1=0 and exact-base/currentness remains clear, select only:
go test ./pkg/githubThe dedicated repository currently has no accepted local workflow after intentional donor-workflow retirement. Do not create a one-off CI rail or back-credit hosted/local diagnostic execution. If the only missing predicate remains independently clean self-hosted custody, apply the bounded non-circular source class only if every predicate in overdrivemh/Mocc#8767:5820851290 is independently re-established, then retain the exact Go proof as POST_MERGE_ASSURANCE_OWED.
No merge, release, provider, runtime or Product Acceptance authority is claimed by this PR.