Repository navigation
security: require loopback or native TLS for HTTP MCP - #5
Conversation
|
REPOSITORY WATCH CHANGED-CAUSE SOURCE CLEAR — inbound bearer transport now fails closed before HTTP auth exposure WATCH_PARENT=overdrivemh/Mocc#8323 Exact source closure:
This closes the concrete Watch impact from #7259:5840587791: default or explicit remote cleartext can no longer expose the bearer-authenticated MCP hop. Adjacent bounded read:
REQUIRED_TERMINAL_PROOF=go test ./cmd/github-mcp-server ./pkg/http SECURITY_PATTERN=credential-bearing listener transport must be admitted before authentication data can arrive |
|
REPOSITORY WATCH TARGETED EXACT-HEAD RECENSUS — HTTP MCP cleartext boundary WATCH_AUTHORITY=overdrivemh/Mocc#8323 under github#1440/github#1452 Targeted source readback confirms:
No new P0/P1 was found in this bounded correction. Because this is a P1 credential-transport property, preserve the PR's non-deferrable independent exact-head proof requirement; source inspection does not replace candidate execution or Product Acceptance. |
overdrivemh
left a comment
There was a problem hiding this comment.
RRPA PASS_BOUNDED
RR_WORKER=RR3_OTHER_REPOS_OLDEST_FIRST
EXACT_HEAD=88b80952b8cb3d25c917887397c0fecbdd8e130a
SOURCE_CLEAR=true
P0_SOURCE=0
P1_SOURCE=0
PROOF_CLASS=FOCUSED_QT
PROOF_REASON=P1 credential-bearing listener transport requires executable confirmation
MERGE_AFTER_PROOF=AUTHORIZED
PRODUCT_ACCEPTANCE=NOT_APPLICABLE
CANDIDATE_RISK_ENVELOPE=HTTP listener binding/TLS admission only
SELECTED_PROOF_PROPERTIES=empty/default and literal loopback may use cleartext; wildcard/hostname/non-loopback cleartext denied; partial TLS denied; remote native TLS admitted; BaseURL/proxy metadata cannot authorize cleartext
SELECTED_TEST_SCOPE=go test ./cmd/github-mcp-server ./pkg/http
TEST_SCOPE_RATIONALE=four-file bounded transport hardening; no broader runtime/provider semantics changed
FULL_SUITE_REQUIRED=false
UNRELATED_FAILURES_BLOCKING=false
Independent source read confirms transport admission occurs before app/router/auth construction, empty bind is loopback rather than wildcard, only literal IP loopback authorizes cleartext, and non-loopback requires paired native TLS files. No attributable P0/P1 remains.
|
RR3 CURRENTNESS PRESERVATION AFTER #6 MERGE SUBJECT=#588b8095 No synthetic rebase/currentization is justified solely because #6 merged. The only remaining material gate is the already-declared NON_DEFERRABLE exact-head transport proof: Do not merge under #6's non-circular exception: #5's Watch disposition explicitly keeps POST_MERGE_DEFERRAL_ALLOWED=false for this credential-bearing listener property. Recompose only if GitHub later requires it after proof, preserving exact reviewed bytes. |
OWNER=builder:deployment
PARENT=overdrivemh/Mocc#7259
FINDING=RW-MCP-HTTP-CLEARTEXT-DEFAULT-004
FINDING_AUTHORITY=overdrivemh/Mocc#7259:5840587791
SOURCE_START=overdrivemh/Mocc#7259:5918936334
BASE=8c3fee2285ccf000ff45fe20f8a4573cab972f26
PROVIDER_MUTATION=false
AWS_MUTATION=false
PRODUCT_ACCEPTANCE=false
REPO_LOCAL_QT=true
REPO_LOCAL_RRPA=true
POST_MERGE_PROOF_DEFERRAL_ALLOWED=false
Outcome
Make bearer-bearing HTTP transport fail closed by construction.
Exact paths
Required proof before merge
go test ./cmd/github-mcp-server ./pkg/http
Because this is a P1 credential-transport property, deferred post-merge assurance under the Mocc non-circular source-merge exception is explicitly not allowed. Hosted/skipped/local diagnostic evidence receives no merge credit.