Repository navigation
fix(sdk): bounds-check little-endian reads and remote byte ranges (DSPX-4591) - #1087
Open
dmihalcik-virtru wants to merge 1 commit into
Open
dmihalcik-virtru wants to merge 1 commit into
dmihalcik-virtru wants to merge 1 commit into
Conversation
…PX-4591) - readUInt16LE/readUInt32LE throw InvalidFileError on out-of-range, negative or non-integer offsets instead of coercing undefined to 0 - fromUrl refuses non-integer byte ranges before building a Range header Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 14, 2026
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://virtru.atlassian.net/browse/DSPX-4591
Part of finding 6 (no file-bounds checks) of the DSPX-4591 zip conformance audit, split
out of #1079. Neither change depends on the zip reader rework in #1017, so this is based
on
main.What / why
readUInt16LE/readUInt32LE(lib/tdf3/src/utils/index.ts) now throwInvalidFileErroron out-of-range, negative or non-integer offsets. Indexing a typedarray out of range yields
undefined, and bitwise operators coerce that to 0. So anunchecked read of a truncated or hostile buffer used to return a plausible-looking
number instead of failing.
readUInt64LEbuilds onreadUInt32LE, so it is coveredtoo.
fromUrl(lib/src/seekable.ts) refuses non-integer byte ranges (NaN,1e21,0.5,Infinity) before building a Range header. Offsets are often derived from theuntrusted file being read.
Tests
lib/tests/mocha/unit/byte-readers.spec.tscovers in-range reads, reads past theend, and negative and non-integer offsets. It has its own file so it doesn't conflict
with the
zip.spec.tschanges in fix(sdk): parse the zip EOCD and honour zip64 extras by sentinel (DSPX-4591) #1017 and fix(sdk): typed errors and bounds checks for hostile zip offsets (DSPX-4591) #1079.lib/tests/mocha/unit/seekable.spec.tschecks thatfromUrlrejects non-integerranges with
InvalidFileErrorwithout making a request.Checks run
cd lib && npx mocha(full suite, 509 passing) passes, as does prettier and eslint on the changed files.