Override default build_root_image to use Go 1.23: release-4.15#281
Conversation
|
Skipping CI for Draft Pull Request. |
The newer OTE (openshift-test-ext) requires a minimum of go version 1.23. **rhel-9-release-golang-1.23-openshift-4.15** does not exist however rhel-9-release-golang-1.23-openshift-4.16 does. This serves as a workaround which is likely easier to accomplish the goals of the OTE migration as opposed to downgrading openshift-test-ext to an earlier version. Signed-off-by: Dan Childers <dchilder@redhat.com>
b0cf89b to
72e94d9
Compare
|
/assign @mandre |
|
@danchild: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @danchild |
|
@danchild: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mandre
left a comment
There was a problem hiding this comment.
Let's see if this fixes our issue. I suspect test platform automation might have something to say when the image version doesn't match the branch, we'll see.
In this case I believe it's acceptable since this is just for building a test suite, and it doesn't end up in the product.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ccb44ed
into
openshift:release-4.15
This is an extension of of work in #274
The openstack-test suites use go version 1.20 which accepts language versions such as 1.20 in the go.mod. Something like 1.23.0 is rejected outright. Starting in go version 1.21, the patch version becomes mandatory when running
go mod, and since OTE requires 1.23, the following error is returned when building the binary (CI defaults to using 1.20 for the build for release-4.15):We need to keep openshift-tests around while testing OTE. So as a workaround, it's easier and more consistent to continue using the most recent OTE versions and use a build container that uses go 1.23. rhel-9-release-golang-1.23-openshift-4.15 does not exist however rhel-9-release-golang-1.23-openshift-4.16 does (it's earliest supported tag using Go 1.23).
After we migrate fully to OTE, this workaround will no longer be needed and therefore will be dropped from the repository.