Skip to content

Override default build_root_image to use Go 1.23: release-4.15#281

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.15from
shiftstack:override-build-image-4.15
Jul 13, 2026
Merged

Override default build_root_image to use Go 1.23: release-4.15#281
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.15from
shiftstack:override-build-image-4.15

Conversation

@danchild

@danchild danchild commented Jul 8, 2026

Copy link
Copy Markdown
Member

This is an extension of of work in #274

The openstack-test suites use go version 1.20 which accepts language versions such as 1.20 in the go.mod. Something like 1.23.0 is rejected outright. Starting in go version 1.21, the patch version becomes mandatory when running go mod, and since OTE requires 1.23, the following error is returned when building the binary (CI defaults to using 1.20 for the build for release-4.15):

cd tests-extension && GOTOOLCHAIN=auto GOSUMDB=sum.golang.org go build -o /go/src/github.com/openshift/openstack-test/bin/openstack-test-tests-ext ./cmd/extension
go: errors parsing go.mod:
/go/src/github.com/openshift/openstack-test/tests-extension/go.mod:3: invalid go version '1.23.0': must match format 1.23

We need to keep openshift-tests around while testing OTE. So as a workaround, it's easier and more consistent to continue using the most recent OTE versions and use a build container that uses go 1.23. rhel-9-release-golang-1.23-openshift-4.15 does not exist however rhel-9-release-golang-1.23-openshift-4.16 does (it's earliest supported tag using Go 1.23).

After we migrate fully to OTE, this workaround will no longer be needed and therefore will be dropped from the repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2026
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

The newer OTE (openshift-test-ext) requires a minimum of go
version 1.23. **rhel-9-release-golang-1.23-openshift-4.15**
does not exist however rhel-9-release-golang-1.23-openshift-4.16 does.

This serves as a workaround which is likely easier to accomplish
the goals of the OTE migration as opposed to downgrading
openshift-test-ext to an earlier version.

Signed-off-by: Dan Childers <dchilder@redhat.com>
@danchild danchild force-pushed the override-build-image-4.15 branch from b0cf89b to 72e94d9 Compare July 8, 2026 15:08
@danchild

danchild commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/assign @mandre

@danchild danchild marked this pull request as ready for review July 8, 2026 15:09
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2026
@openshift-ci openshift-ci Bot requested review from EmilienM and itzikb-redhat July 8, 2026 15:11
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@danchild: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danchild

danchild commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/verified by @danchild

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@danchild: This PR has been marked as verified by @danchild.

Details

In response to this:

/verified by @danchild

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mandre mandre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this fixes our issue. I suspect test platform automation might have something to say when the image version doesn't match the branch, we'll see.
In this case I believe it's acceptable since this is just for building a test suite, and it doesn't end up in the product.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2026
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit ccb44ed into openshift:release-4.15 Jul 13, 2026
5 checks passed
@openshift-merge-bot openshift-merge-bot Bot deleted the override-build-image-4.15 branch July 13, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants