Override default build_root_image to use Go 1.21: release-4.15#289
Override default build_root_image to use Go 1.21: release-4.15#289danchild wants to merge 1 commit into
Conversation
As a continuation of openshift#281, OpenShift CI isn't picking up the `rhel-9-release-golang-1.23-openshift-4.16` configuration. So, the build stage is still using go 1.20 which results in the same error. The .ci-operator.yaml override works as expected in previous releases (e.g., release-4.18), so it is possible that OCP CI is refusing to use the 4.16 tag. The patch version in go.mod was introduced in go v1.21 and OTE build has been woking with 1.21 in the Containerfile; so, the `rhel-9-release-golang-1.21-openshift-4.15` tag is selected here to build the OTE binary whose go.mod references a go version with a patch number (e.g. go 1.23.0 as opposed to go 1.23) and use correct openshift release tags. This serves as a workaround which is likely easier to accomplish the goals of the OTE migration as opposed to downgrading openshift-test-ext to an earlier version. Signed-off-by: Dan Childers <dchilder@redhat.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/verified by @danchild |
openshift-ci-robot
added
the
verified
|
@danchild: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danchild: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This is an extension of of work in #274 and #281
OpenShift CI isn't picking up
the
rhel-9-release-golang-1.23-openshift-4.16configuration.So, the build stage is still using go 1.20 which results in the
same error.
The .ci-operator.yaml override works as expected in previous
releases (e.g., release-4.18), so it is possible that OCP
CI is refusing to use the 4.16 tag as @mandre predicted in
#281.
The patch version specifier in go.mod was introduced in go 1.21 and OTE build
has been woking with 1.21 in the Containerfile; so, the
rhel-9-release-golang-1.21-openshift-4.15tag is selectedhere to build the OTE with a go.mod reference to 1.23.0 ( as opposed to go 1.23)
and use correct OpenShift release tags.
This serves as a workaround which is likely easier to accomplish
the goals of the OTE migration as opposed to downgrading
openshift-test-ext to an earlier version.