Skip to content

Potential fix for code scanning alert no. 355: Redundant null check due to previous dereference #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matteius wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −13
Draft

Potential fix for code scanning alert no. 355: Redundant null check due to previous dereference #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cf28d6
Potential fix for code scanning alert no. 355: Redundant null check d…
matteius Nov 9, 2026
0a02dee
lightnvr-rs: regenerate from C
github-actions[bot] Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust/MANIFEST.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 7 additions & 9 deletions rust/generated/src__core__observation_retention.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions src/core/observation_retention.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,7 @@ static int remove_asset_file(const char *root, const char *stored, int *deleted)
if (!stored || !*stored) return 0;
char path[OBS_PATH_SIZE];
if (resolve_asset_path(root, stored, path, sizeof(path)) != 0) {
if (stored && *stored)
log_warn("Observation asset path is outside the evidence tree; not deleting");
log_warn("Observation asset path is outside the evidence tree; not deleting");
/* A corrupt path is never a file this subsystem may remove. */
return 0;
}
Expand Down
Loading