Repository navigation
Conversation
…ue to previous dereference Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Generated by tools/rust-transpile/generate.py for 3f473bf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/opensensor/lightNVR/security/code-scanning/355
General fix approach: when a pointer is validated/dereferenced earlier in the same control flow, avoid repeating null checks later. Either move checks before first dereference, or remove later redundant checks.
Best fix here (no functionality change): in
src/core/observation_retention.c, insideremove_asset_file, replace:if (stored && *stored) log_warn(...);with an unconditional
log_warn(...), because reaching that block already impliesstoredis non-null and non-empty due to line 124 early return.No imports, new methods, or new definitions are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.