Skip to content

fix(background-terminals): extend Windows taskkill force window #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tt-a1i merged 2 commits into from
Sep 24, 2026
+3 −2
Merged

fix(background-terminals): extend Windows taskkill force window #616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b68e2f2
fix(background-terminals): extend Windows taskkill force window
outlier27-cell Sep 23, 2026
fba5654
Merge branch 'main' into fix/background-taskkill-windows-budget
tt-a1i Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions extensions/background-terminals/src/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ export const MAX_SPILL_BYTES_PER_STREAM = 256 * 1024 * 1024;
export const MAX_SPILL_BYTES_PER_SESSION = 512 * 1024 * 1024;
const STOP_TIMEOUT_MS = 5_000;
/** SIGTERM is normally enough; the second deadline covers a wedged process. */
const FORCE_KILL_AFTER_MS = 2_000;
const FORCE_CLOSE_WAIT_MS = 500;
// Reserve more of the same 2.5s termination budget for Windows taskkill /T /F.
const FORCE_KILL_AFTER_MS = process.platform === "win32" ? 1_500 : 2_000;
const FORCE_CLOSE_WAIT_MS = process.platform === "win32" ? 1_000 : 500;
/** Reserve this inside each existing termination phase for helper closure. */
const TASKKILL_HELPER_CLOSE_WAIT_MS = 100;
/** After termination, how long to wait for the natural close→flush→settle
Expand Down
Loading