fix(background-terminals): extend Windows taskkill force window - #616
Open
outlier27-cell wants to merge 1 commit into
Open
outlier27-cell wants to merge 1 commit into
outlier27-cell wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #615. On Windows, the background-terminal shutdown preserves a 2.5s total budget but allocates only 500ms to the force
taskkill /T /Fphase (400ms before its helper-close reserve). On this host, the force helper regularly needs longer, so a real descendant-tree shutdown can become fail-closedunresolvedeven though the helper would complete within the existing overall bound.This does not reopen #408/#412: a helper timeout still remains unresolved and never falls back to shell-only termination.
Value
Gives Windows process-tree termination enough bounded time to complete on slower
taskkillhosts while retaining the existing lifecycle deadline and fail-closed behavior.Approach
Validation
origin/main43cd2e94cc584f81cc1f27512ae99c9a4099b231.kill settles a never-exiting processpassed in about 3.28s.taskkillcontract tests passed.bun run checkpassed.bun run testwas started; it remained running after the command observer returned. This repository has an existing post-edit real-Pi timeout/hang cluster, so this PR does not claim a full-suite pass. A combined real-process pressure filter also still made the descendant assertion timing-sensitive; this is recorded in fix(background-terminals): give Windows taskkill /T /F enough bounded time #615 rather than hidden.Impact