Skip to content

fix(git-read): reject NUL bytes in paths #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tt-a1i merged 2 commits into from
Sep 24, 2026
+13 −1
Merged

fix(git-read): reject NUL bytes in paths #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b9ad43
fix(git-read): reject NUL bytes in paths
outlier27-cell Sep 23, 2026
f88163d
Merge branch 'main' into audit/git-path-nul
tt-a1i Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extensions/git-read/src/args.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ export function isSafeRevision(revision: string): boolean {
const REPO_PATH_PATTERN = /^[^:/\\?#*[\]'"\s][^:/\\?#*[\]'"\s]*$/;

export function isSafeRepoPath(value: string): boolean {
if (value.length === 0 || value.length > 512) return false;
if (value.length === 0 || value.length > 512 || value.includes("\0"))
return false;
const segments = value.split("/");
for (const segment of segments) {
if (segment === "" || segment === "." || segment === "..") return false;
Expand Down
11 changes: 11 additions & 0 deletions tests/extensions/git-read/args.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,3 +149,14 @@ test("buildLogArgs clamps the limit and validates inputs", () => {
assert.throws(() => buildLogArgs({ revision: "-n5" }), InvalidRevisionError);
assert.throws(() => buildLogArgs({ file: "a/../b" }), InvalidPathError);
});

test("git argv builders reject NUL bytes in repository paths", () => {
const path = "src\0secret.ts";

assert.throws(
() => buildShowArgs({ revision: "HEAD", path }),
InvalidPathError,
);
assert.throws(() => buildDiffArgs({ path }), InvalidPathError);
assert.throws(() => buildLogArgs({ file: path }), InvalidPathError);
});
Loading