fix(git-read): reject NUL bytes in paths - #613
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nnCloses #612. Git path validation accepted NUL bytes, then Node rejected the argv at spawn time withERR_INVALID_ARG_VALUEinstead of OpenPI returningInvalidPathError.nn## ValuennReject unsupported paths at the tool boundary with a stable, actionable error.nn## ApproachnnReject NUL in the shared repository-path validator and cover show, diff, and log argv builders.nn## Validationnn- Red: latest main acceptedsrc\0secret.ts; Node rejected it only at spawn.n- Focused args tests: 4/4 passed.n- Git-read suite: 27/27 passed.n-bun run check: passed.n-bun run test: changed Git-read tests passed in the full run; it then reproduced the known unrelated Windows real-Pi post-edit timeout cluster, so no full-suite pass is claimed.nn## Impactnn- User-visible: NUL paths return existingInvalidPathError.n- Model-visible tools, runtime/lifecycle, persistence: none.n- Compatibility: NUL cannot be passed to Node process argv or name a normal repository path.