8381379: Support std/dstOffset attributes in CLDR's metazone definitions - #757
Open
gnu-andrew wants to merge 1 commit into
Open
8381379: Support std/dstOffset attributes in CLDR's metazone definitions#757gnu-andrew wants to merge 1 commit into
gnu-andrew wants to merge 1 commit into
Conversation
4 tasks
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports support for the
dstOffsetattribute to the CLDR converter, which is necessary to support new timezone changes in Vancouver (tzdata2026b) and Alberta (tzdata2026c) correctly.As there are no
dstOffsetattributes currently in the CLDR data in 25u (version 47), this doesn't yet do much. The test for it will be writing a fix for JDK-8390388: "Cherry-pick tz attributes from newer CLDR data for jdk25u and earlier" which doesn't exist for 27 as it has the newer CLDR withdstOffset.I actually thought the
TimeZoneNamesTest.javachanges here might fail without first having the attributes, but this was not the case. So this and its dependency #756 should be able to go in nearly clean and then we get to the more tricky but interesting part. The test passes because of:which is changed in JDK-8371842: Update CLDR to Version 48.2, which we'll need to backport hunks of for JDK-8390388. With that change & tzdata 2026b (already in 25u), Vancouver should still be reporting "Pacific Daylight Time" in December.
The only adjustments were the copyright header on
DateTimeFormatterBuilder.javaand the bug ID placement ontest/jdk/sun/util/resources/cldr/TimeZoneNamesTest.java, due to 8382020 & 8384043 going in first for the last tzdata update. As it stands, all tests pass as on the previous PR:Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/757/head:pull/757$ git checkout pull/757Update a local copy of the PR:
$ git checkout pull/757$ git pull https://git.openjdk.org/jdk25u-dev.git pull/757/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 757View PR using the GUI difftool:
$ git pr show -t 757Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/757.diff
Using Webrev
Link to Webrev Comment