8381379: Support std/dstOffset attributes in CLDR's metazone definitions - #762
Closed
rm-gh-8 wants to merge 1 commit into
Closed
8381379: Support std/dstOffset attributes in CLDR's metazone definitions#762rm-gh-8 wants to merge 1 commit into
rm-gh-8 wants to merge 1 commit into
Conversation
rm-gh-8
marked this pull request as ready for review
August 26, 2026 13:15
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
Bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
Bot
added
backport
Member
|
I see that @gnu-andrew was first to publish: #757. I suggest to close this PR and cooperate in the first one. You are in the perfect position to cross-check Andrew's work :) |
Contributor
Author
Contributor
Author
|
This matters to us, so I'll keep it open until the duplicate has been merged. |
Contributor
Author
|
Discussed offline. Withdrawing PR due to duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8381379: Support std/dstOffset attributes in CLDR's metazone definitions.
This PR fixes the time zone name formatting for zones like Europe/Dublin by following the explicit metazone dstOffset attribute.
This PR is not clean because of a merge conflict in the copyright header in DateTimeFormatterBuilder.java and a merge conflict in the bug list of TimeZoneNamesTest.java, due to skipped commits relating to CLDR 48+ which is not in Java 25.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/sun/util/resources/cldr
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/762/head:pull/762$ git checkout pull/762Update a local copy of the PR:
$ git checkout pull/762$ git pull https://git.openjdk.org/jdk25u-dev.git pull/762/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 762View PR using the GUI difftool:
$ git pr show -t 762Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/762.diff
Using Webrev
Link to Webrev Comment